Skip to content

Commit f322f86

Browse files
LemmingAvalanchegitster
authored andcommitted
config: use --value=<pattern> consistently
This option was introduced in a series of commits from fe3ccc7 (Merge branch 'ps/config-subcommands', 2024-05-15). But two styles were used for the value provided to the option: 1. Synopsis: `--value=<value>` 2. Deprecated Modes: `--value=<pattern>` (2) is also used in the synopsis on the command. Use (2) consistently throughout since it’s a pattern in the general case (`value` sounds more generic). Acked-by: Patrick Steinhardt <[email protected]> Signed-off-by: Kristoffer Haugsbakk <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 88a4ed4 commit f322f86

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

Documentation/git-config.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ SYNOPSIS
1010
--------
1111
[verse]
1212
'git config list' [<file-option>] [<display-option>] [--includes]
13-
'git config get' [<file-option>] [<display-option>] [--includes] [--all] [--regexp] [--value=<value>] [--fixed-value] [--default=<default>] <name>
14-
'git config set' [<file-option>] [--type=<type>] [--all] [--value=<value>] [--fixed-value] <name> <value>
15-
'git config unset' [<file-option>] [--all] [--value=<value>] [--fixed-value] <name>
13+
'git config get' [<file-option>] [<display-option>] [--includes] [--all] [--regexp] [--value=<pattern>] [--fixed-value] [--default=<default>] <name>
14+
'git config set' [<file-option>] [--type=<type>] [--all] [--value=<pattern>] [--fixed-value] <name> <value>
15+
'git config unset' [<file-option>] [--all] [--value=<pattern>] [--fixed-value] <name>
1616
'git config rename-section' [<file-option>] <old-name> <new-name>
1717
'git config remove-section' [<file-option>] <name>
1818
'git config edit' [<file-option>]

builtin/config.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717

1818
static const char *const builtin_config_usage[] = {
1919
N_("git config list [<file-option>] [<display-option>] [--includes]"),
20-
N_("git config get [<file-option>] [<display-option>] [--includes] [--all] [--regexp] [--value=<value>] [--fixed-value] [--default=<default>] <name>"),
21-
N_("git config set [<file-option>] [--type=<type>] [--all] [--value=<value>] [--fixed-value] <name> <value>"),
22-
N_("git config unset [<file-option>] [--all] [--value=<value>] [--fixed-value] <name>"),
20+
N_("git config get [<file-option>] [<display-option>] [--includes] [--all] [--regexp] [--value=<pattern>] [--fixed-value] [--default=<default>] <name>"),
21+
N_("git config set [<file-option>] [--type=<type>] [--all] [--value=<pattern>] [--fixed-value] <name> <value>"),
22+
N_("git config unset [<file-option>] [--all] [--value=<pattern>] [--fixed-value] <name>"),
2323
N_("git config rename-section [<file-option>] <old-name> <new-name>"),
2424
N_("git config remove-section [<file-option>] <name>"),
2525
N_("git config edit [<file-option>]"),
@@ -33,17 +33,17 @@ static const char *const builtin_config_list_usage[] = {
3333
};
3434

3535
static const char *const builtin_config_get_usage[] = {
36-
N_("git config get [<file-option>] [<display-option>] [--includes] [--all] [--regexp=<regexp>] [--value=<value>] [--fixed-value] [--default=<default>] <name>"),
36+
N_("git config get [<file-option>] [<display-option>] [--includes] [--all] [--regexp=<regexp>] [--value=<pattern>] [--fixed-value] [--default=<default>] <name>"),
3737
NULL
3838
};
3939

4040
static const char *const builtin_config_set_usage[] = {
41-
N_("git config set [<file-option>] [--type=<type>] [--comment=<message>] [--all] [--value=<value>] [--fixed-value] <name> <value>"),
41+
N_("git config set [<file-option>] [--type=<type>] [--comment=<message>] [--all] [--value=<pattern>] [--fixed-value] <name> <value>"),
4242
NULL
4343
};
4444

4545
static const char *const builtin_config_unset_usage[] = {
46-
N_("git config unset [<file-option>] [--all] [--value=<value>] [--fixed-value] <name>"),
46+
N_("git config unset [<file-option>] [--all] [--value=<pattern>] [--fixed-value] <name>"),
4747
NULL
4848
};
4949

0 commit comments

Comments
 (0)