Skip to content

Commit f50fee4

Browse files
committed
builtin/notes.c: mark file-scope private symbols as static
Signed-off-by: Junio C Hamano <[email protected]>
1 parent 83379df commit f50fee4

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

builtin.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ struct fmt_merge_msg_opts {
2121

2222
extern int fmt_merge_msg(struct strbuf *in, struct strbuf *out,
2323
struct fmt_merge_msg_opts *);
24-
extern void commit_notes(struct notes_tree *t, const char *msg);
2524

2625
struct notes_rewrite_cfg {
2726
struct notes_tree **trees;
@@ -33,7 +32,6 @@ struct notes_rewrite_cfg {
3332
int mode_from_env;
3433
};
3534

36-
combine_notes_fn parse_combine_notes_fn(const char *v);
3735
struct notes_rewrite_cfg *init_copy_notes_for_rewrite(const char *cmd);
3836
int copy_note_for_rewrite(struct notes_rewrite_cfg *c,
3937
const unsigned char *from_obj, const unsigned char *to_obj);

builtin/notes.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
#include "string-list.h"
2020
#include "notes-merge.h"
2121

22+
static void commit_notes(struct notes_tree *t, const char *msg);
23+
static combine_notes_fn parse_combine_notes_fn(const char *v);
24+
2225
static const char * const git_notes_usage[] = {
2326
N_("git notes [--ref <notes_ref>] [list [<object>]]"),
2427
N_("git notes [--ref <notes_ref>] add [-f] [-m <msg> | -F <file> | (-c | -C) <object>] [<object>]"),
@@ -288,7 +291,7 @@ static int parse_reedit_arg(const struct option *opt, const char *arg, int unset
288291
return parse_reuse_arg(opt, arg, unset);
289292
}
290293

291-
void commit_notes(struct notes_tree *t, const char *msg)
294+
static void commit_notes(struct notes_tree *t, const char *msg)
292295
{
293296
struct strbuf buf = STRBUF_INIT;
294297
unsigned char commit_sha1[20];
@@ -312,7 +315,7 @@ void commit_notes(struct notes_tree *t, const char *msg)
312315
strbuf_release(&buf);
313316
}
314317

315-
combine_notes_fn parse_combine_notes_fn(const char *v)
318+
static combine_notes_fn parse_combine_notes_fn(const char *v)
316319
{
317320
if (!strcasecmp(v, "overwrite"))
318321
return combine_notes_overwrite;

0 commit comments

Comments
 (0)