git-svn: Cache results of running the executable "git config"

James Y Knight · Eric Wong · commit f5549afd5d6c · 2011-04-09T22:43:35.000Z
Running programs is not cheap!

Signed-off-by: James Y Knight &lt;jknight@itasoftware.com&gt;
Signed-off-by: Alejandro R. Sedeño &lt;asedeno@mit.edu&gt;
Acked-by: Eric Wong &lt;normalperson@yhbt.net&gt;
diff --git a/git-svn.perl b/git-svn.perl
@@ -59,6 +59,7 @@ sub _req_svn {
 use Getopt::Long qw/:config gnu_getopt no_ignore_case auto_abbrev/;
 use IPC::Open3;
 use Git;
+use Memoize;  # core since 5.8.0, Jul 2002
 
 BEGIN {
 	# import functions from Git into our packages, en masse
@@ -72,6 +73,8 @@ BEGIN
 			*{"${package}::$_"} = \&{"Git::$_"};
 		}
 	}
+	Memoize::memoize 'Git::config';
+	Memoize::memoize 'Git::config_bool';
 }
 
 my ($SVN);
@@ -3210,6 +3213,8 @@ sub has_no_changes {
 		Memoize::unmemoize 'check_cherry_pick';
 		Memoize::unmemoize 'has_no_changes';
 	}
+
+	Memoize::memoize 'Git::SVN::repos_root';
 }
 
 END {

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,7 @@ sub _req_svn {`
`59`	`59`	`use Getopt::Long qw/:config gnu_getopt no_ignore_case auto_abbrev/;`
`60`	`60`	`use IPC::Open3;`
`61`	`61`	`use Git;`
	`62`	`+use Memoize; # core since 5.8.0, Jul 2002`
`62`	`63`
`63`	`64`	`BEGIN {`
`64`	`65`	`# import functions from Git into our packages, en masse`
`@@ -72,6 +73,8 @@ BEGIN`
`72`	`73`	`*{"${package}::$_"} = \&{"Git::$_"};`
`73`	`74`	`}`
`74`	`75`	`}`
	`76`	`+ Memoize::memoize 'Git::config';`
	`77`	`+ Memoize::memoize 'Git::config_bool';`
`75`	`78`	`}`
`76`	`79`
`77`	`80`	`my ($SVN);`
`@@ -3210,6 +3213,8 @@ sub has_no_changes {`
`3210`	`3213`	`Memoize::unmemoize 'check_cherry_pick';`
`3211`	`3214`	`Memoize::unmemoize 'has_no_changes';`
`3212`	`3215`	`}`
	`3216`	`+`
	`3217`	`+ Memoize::memoize 'Git::SVN::repos_root';`
`3213`	`3218`	`}`
`3214`	`3219`
`3215`	`3220`	`END {`