Skip to content

Commit f78e2dd

Browse files
ramsay-jonesgitster
authored andcommitted
Makefile: drop -Wno-universal-initializer from SP_EXTRA_FLAGS
Commit 1c96642 ("sparse: allow '{ 0 }' to be used without warnings", 2020-05-22) added -Wno-universal-initializer to the SP_EXTRA_FLAGS in order to suppress potential sparse warnings from using '{0}' as an aggregate initializer. At that time, the default was for sparse to issue warnings (i.e. the default was -Wuniversal-initializer) if such an initializer was used to initialize an aggregate whose first member was a pointer type. However, this default was changed just a few days later to -Wno-universal-initializer (first released in sparse v0.6.2) and has been so in all subsequent release versions of sparse. Thus, including -Wno-universal-initializer in the SP_EXTRA_FLAGS variable is redundant. Remove the unnecessary warning flag from SP_EXTRA_FLAGS, essentially reverting commit 1c96642. Signed-off-by: Ramsay Jones <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1c4a234 commit f78e2dd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1376,7 +1376,7 @@ PTHREAD_CFLAGS =
13761376

13771377
# For the 'sparse' target
13781378
SPARSE_FLAGS ?= -std=gnu99
1379-
SP_EXTRA_FLAGS = -Wno-universal-initializer
1379+
SP_EXTRA_FLAGS =
13801380

13811381
# For informing GIT-BUILD-OPTIONS of the SANITIZE=leak,address targets
13821382
SANITIZE_LEAK =

0 commit comments

Comments
 (0)