Skip to content

Commit f9e9c0d

Browse files
sunshinecogitster
authored andcommitted
lib-gpg: drop unnecessary "missing GPG" warning
When 37d3e85 (t7004: factor out gpg setup, 2011-09-07) pulled gpg detection code out of t7004-tag.sh and turned it into a standard test prerequisite, it added an unconditional "missing GPG" warning when gpg is not detected. However, this is redundant since all tests which require GPG already warn via either 'test_expect_success GPG' ("skipping: missing GPG") on a test-by-test basis, or when skipping all tests in a script ("skipping all foobar tests; missing GPG"). Consequently, the extra warning from lib-gpg.sh is unnecessary, so retire it. Signed-off-by: Eric Sunshine <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent ab5d01a commit f9e9c0d

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

t/lib-gpg.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
#!/bin/sh
22

33
gpg_version=$(gpg --version 2>&1)
4-
if test $? = 127; then
5-
say "You do not seem to have gpg installed"
6-
else
4+
if test $? != 127
5+
then
76
# As said here: http://www.gnupg.org/documentation/faqs.html#q6.19
87
# the gpg version 1.0.6 didn't parse trust packets correctly, so for
98
# that version, creation of signed tags using the generated key fails.

0 commit comments

Comments
 (0)