Skip to content

Commit fb6644a

Browse files
devzero2000gitster
authored andcommitted
git-revert.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <[email protected]> Reviewed-by: Matthieu Moy <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 6aeb30e commit fb6644a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

contrib/examples/git-revert.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ cherry-pick)
137137
q
138138
}'
139139

140-
logmsg=`git show -s --pretty=raw --encoding="$encoding" "$commit"`
140+
logmsg=$(git show -s --pretty=raw --encoding="$encoding" "$commit")
141141
set_author_env=`echo "$logmsg" |
142142
LANG=C LC_ALL=C sed -ne "$pick_author_script"`
143143
eval "$set_author_env"

0 commit comments

Comments
 (0)