Skip to content

Commit fb8dfc1

Browse files
jholgitster
authored andcommitted
git-p4: remove "debug" verb
The git-p4 "debug" verb is described as "A tool to debug the output of p4 -G". The verb is not documented in any detail, but implements a function which executes an arbitrary p4 command with the -G flag, which causes perforce to format all output as marshalled Python dictionary objects. The verb was implemented early in the history of git-p4, and may once have served a useful purpose to the authors in the early stages of development. However, the "debug" verb is no longer being used by the current developers (and users) of git-p4, and whatever purpose the verb previously offered is easily replaced by invoking p4 directly. This patch therefore removes the verb from git-p4. Signed-off-by: Joel Holdsworth <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 597af31 commit fb8dfc1

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

git-p4.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1532,21 +1532,6 @@ def loadUserMapFromCache(self):
15321532
except IOError:
15331533
self.getUserMapFromPerforceServer()
15341534

1535-
class P4Debug(Command):
1536-
def __init__(self):
1537-
Command.__init__(self)
1538-
self.options = []
1539-
self.description = "A tool to debug the output of p4 -G."
1540-
self.needsGit = False
1541-
1542-
def run(self, args):
1543-
j = 0
1544-
for output in p4CmdList(args):
1545-
print('Element: %d' % j)
1546-
j += 1
1547-
print(output)
1548-
return True
1549-
15501535
class P4RollBack(Command):
15511536
def __init__(self):
15521537
Command.__init__(self)
@@ -4363,7 +4348,6 @@ def printUsage(commands):
43634348
print("")
43644349

43654350
commands = {
4366-
"debug" : P4Debug,
43674351
"submit" : P4Submit,
43684352
"commit" : P4Submit,
43694353
"sync" : P4Sync,

0 commit comments

Comments
 (0)