Skip to content

Commit fbc812a

Browse files
draenoggitster
authored andcommitted
Fix '\%o' for printf from coreutils
The printf utility provided by coreutils when interpreting '\%o' format does not recognize %o as formatting directive. For example printf '\%o 0 returns \%o and warning: ignoring excess arguments, starting with ‘0’, which results in failed tests in t5309-pack-delta-cycles.sh. In most shells the test ends with success as the printf is a builtin utility. Fix it by using '\\%o' which is interpreted consistently in all versions of printf. Signed-off-by: Kacper Kornet <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 16c159d commit fbc812a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

t/lib-pack.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
# Print the big-endian 4-byte octal representation of $1
1313
uint32_octal () {
1414
n=$1
15-
printf '\%o' $(($n / 16777216)); n=$((n % 16777216))
16-
printf '\%o' $(($n / 65536)); n=$((n % 65536))
17-
printf '\%o' $(($n / 256)); n=$((n % 256))
18-
printf '\%o' $(($n ));
15+
printf '\\%o' $(($n / 16777216)); n=$((n % 16777216))
16+
printf '\\%o' $(($n / 65536)); n=$((n % 65536))
17+
printf '\\%o' $(($n / 256)); n=$((n % 256))
18+
printf '\\%o' $(($n ));
1919
}
2020

2121
# Print the big-endian 4-byte binary representation of $1

0 commit comments

Comments
 (0)