Skip to content

Commit fcd3549

Browse files
committed
Merge branch 'sp/maint-describe-all-tag-warning' into maint
* sp/maint-describe-all-tag-warning: describe: Avoid unnecessary warning when using --all
2 parents f83b9ba + 81dc223 commit fcd3549

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

builtin-describe.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ static void display_name(struct commit_name *n)
158158
n->tag = lookup_tag(n->sha1);
159159
if (!n->tag || parse_tag(n->tag) || !n->tag->tag)
160160
die("annotated tag %s not available", n->path);
161-
if (strcmp(n->tag->tag, n->path))
161+
if (strcmp(n->tag->tag, all ? n->path + 5 : n->path))
162162
warning("tag '%s' is really '%s' here", n->tag->tag, n->path);
163163
}
164164

t/t6120-describe.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,12 @@ check_describe B --tags HEAD^^2^
100100
check_describe B-0-* --long HEAD^^2^
101101
check_describe A-3-* --long HEAD^^2
102102

103+
: >err.expect
104+
check_describe A --all A^0
105+
test_expect_success 'no warning was displayed for A' '
106+
test_cmp err.expect err.actual
107+
'
108+
103109
test_expect_success 'rename tag A to Q locally' '
104110
mv .git/refs/tags/A .git/refs/tags/Q
105111
'

0 commit comments

Comments
 (0)