Skip to content

Commit fdb0424

Browse files
jrngitster
authored andcommitted
docs: manpage XML depends on asciidoc.conf
When building manual pages, the source text is transformed to XML with AsciiDoc before the man pages are generated from the XML with xmlto. Fix the dependencies in the Makefile so that the XML files are rebuilt when asciidoc.conf changes and not just the manual pages from unchanged XML, and move the dependencies from a recipeless rule to the rules with commands that use asciidoc.conf to make the dependencies easier to understand and maintain. Reported-by: John Keeping <[email protected]> Signed-off-by: Jonathan Nieder <[email protected]> Tested-by: John Keeping <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1599999 commit fdb0424

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

Documentation/Makefile

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,8 +178,6 @@ all: html man
178178

179179
html: $(DOC_HTML)
180180

181-
$(DOC_HTML) $(DOC_MAN1) $(DOC_MAN5) $(DOC_MAN7): asciidoc.conf
182-
183181
man: man1 man5 man7
184182
man1: $(DOC_MAN1)
185183
man5: $(DOC_MAN5)
@@ -257,7 +255,7 @@ clean:
257255
$(RM) $(cmds_txt) *.made
258256
$(RM) manpage-base-url.xsl
259257

260-
$(MAN_HTML): %.html : %.txt
258+
$(MAN_HTML): %.html : %.txt asciidoc.conf
261259
$(QUIET_ASCIIDOC)$(RM) $@+ $@ && \
262260
$(ASCIIDOC) -b xhtml11 -d manpage -f asciidoc.conf \
263261
$(ASCIIDOC_EXTRA) -agit_version=$(GIT_VERSION) -o $@+ $< && \
@@ -270,7 +268,7 @@ manpage-base-url.xsl: manpage-base-url.xsl.in
270268
$(QUIET_XMLTO)$(RM) $@ && \
271269
$(XMLTO) -m $(MANPAGE_XSL) $(XMLTO_EXTRA) man $<
272270

273-
%.xml : %.txt
271+
%.xml : %.txt asciidoc.conf
274272
$(QUIET_ASCIIDOC)$(RM) $@+ $@ && \
275273
$(ASCIIDOC) -b docbook -d manpage -f asciidoc.conf \
276274
$(ASCIIDOC_EXTRA) -agit_version=$(GIT_VERSION) -o $@+ $< && \
@@ -286,7 +284,7 @@ technical/api-index.txt: technical/api-index-skel.txt \
286284
$(QUIET_GEN)cd technical && '$(SHELL_PATH_SQ)' ./api-index.sh
287285

288286
technical/%.html: ASCIIDOC_EXTRA += -a git-relative-html-prefix=../
289-
$(patsubst %,%.html,$(API_DOCS) technical/api-index $(TECH_DOCS)): %.html : %.txt
287+
$(patsubst %,%.html,$(API_DOCS) technical/api-index $(TECH_DOCS)): %.html : %.txt asciidoc.conf
290288
$(QUIET_ASCIIDOC)$(ASCIIDOC) -b xhtml11 -f asciidoc.conf \
291289
$(ASCIIDOC_EXTRA) -agit_version=$(GIT_VERSION) $*.txt
292290

0 commit comments

Comments
 (0)