revision: clear the topo-walk flags in reset_revision_walk

glandium · gitster · commit ffa1f28fea00 · 2019-11-25T11:48:47.000+09:00
Not doing so can lead to wrong topo-walks when using the revision walk API
consecutively.

Signed-off-by: Mike Hommey &lt;mh@glandium.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/revision.c b/revision.c
@@ -3088,7 +3088,7 @@ static void set_children(struct rev_info *revs)
 
 void reset_revision_walk(void)
 {
-	clear_object_flags(SEEN | ADDED | SHOWN);
+	clear_object_flags(SEEN | ADDED | SHOWN | TOPO_WALK_EXPLORED | TOPO_WALK_INDEGREE);
 }
 
 static int mark_uninteresting(const struct object_id *oid,

Original file line number	Diff line number	Diff line change
`@@ -3088,7 +3088,7 @@ static void set_children(struct rev_info *revs)`
`3088`	`3088`
`3089`	`3089`	`void reset_revision_walk(void)`
`3090`	`3090`	`{`
`3091`		`- clear_object_flags(SEEN \| ADDED \| SHOWN);`
	`3091`	`+ clear_object_flags(SEEN \| ADDED \| SHOWN \| TOPO_WALK_EXPLORED \| TOPO_WALK_INDEGREE);`
`3092`	`3092`	`}`
`3093`	`3093`
`3094`	`3094`	`static int mark_uninteresting(const struct object_id *oid,`