Update notification "Yes" button does not work when in "Do not disturb" mode

[olfek]

Existing issues matching what you're seeing

• I was not able to find an open or closed issue matching what I'm seeing

Git for Windows version

git version 2.51.0.windows.1

Windows version

Windows 11

Windows CPU architecture

x86_64 (64-bit)

Additional Windows version information

Microsoft Windows [Version 10.0.26100.6584]

Options set during installation

n/a

Other interesting things

n/a

Terminal/shell

n/a

Commands that trigger the issue

scheduled update check

Expected behaviour

n/a

Actual behaviour

Update notification "Yes" button does not work when in "Do not disturb" mode

Repository

n/a

[rimrul]

Do not disturb mode in Windows 11 causes wintoast to immediately exit with the message "The toast has timed out" and exit code 2. I'm unsure what we can do about that.

[dscho]

@mohabouje do you have more insights? I do not see this issue mentioned anywhere in https://github.com/mohabouje/WinToast/issues?q=is%3Aissue%20state%3Aopen%20do%20not%20disturb

[olfek]

@rimrul ---

DND is always on for me, maybe a CLI notification? Kind of like ...

[rimrul]

maybe a CLI notification? Kind of like ...

That would require us injecting text into a random console window, but maybe we could fall back to a message box like we do when toast notifications are unsupported.

[olfek]

@rimrul ---

No that's not what I meant, I often use git on the command line, so when I do, it can print a similar update notification.

And allow me to act on it.

[dscho]

@olfek it's very nice of you to share your desire here.

We need to keep the big picture in mind, though, where users often run git.exe within scripts or even within completely head-less operations launched from 3rd-party applications such as GitHub Desktop.

Further, most users would be appalled if their PowerShell profile all of a sudden started checking for updates upon start-up (and only checking upon start-up would likely not be enough, I would guess, seeing for just how long I keep my PowerShell sessions open).

And of course PowerShell is not the only way people use git.exe interactively, there is Git Bash, and even CMD.

Some of those invocations are done from within, say, GitHub Desktop, too, where Git simply cannot be updated individually, therefore your desired feature would have to suppress the update check in such situations, adding to the complexity of the hypothesized feature.

With these considerations in mind, I don't think that you will find wide-spread support for that idea. I, for one, dislike it, it would disrupt my common workflows just too much.

[olfek]

@dscho ---

Applications that use git internally should be using it in a way that returns machine readable output, using the --porcelain option for example, so those applications shouldn't be affected.

Further, most users would be appalled if their PowerShell profile all of a sudden started checking for updates upon start-up (and only checking upon start-up would likely not be enough, I would guess, seeing for just how long I keep my PowerShell sessions open).

The PowerShell image I posted was supposed to be just an example of a CLI notification, why the weird fixation on PowerShell?

The hypothetical implementation would be the git program displaying the update notification, which has nothing to do with any shells???

[dscho]

Applications that use git internally should be using it in a way that returns machine readable output, using the --porcelain option for example, so those applications shouldn't be affected.

@olfek the --porcelain option is specific to certain Git commands, and isn't parsed before the code location where the message would practically need to be displayed that you so dearly desire that you have a hard time letting go of that idea.

The PowerShell image I posted was supposed to be just an example of a CLI notification, why the weird fixation on PowerShell?

Because no other shell has prior art of such a disruptive message.

The hypothetical implementation would be the git program displaying the update notification, which has nothing to do with any shells???

So you would like to display this all the time (and perform the prerequisite update check all the time, too), regardless whether the command was called interactively or not?

Keep in mind that the process chain is about 4 deep when calling something as simple as git fetch, i.e. the git fetch process spawns another git remote-https process, which in turn spawns a git receive-pack process, which in turn spawns a git index-pack process. If I understood your grand idea correctly, you want each and every one of those to print that message, no matter whether a user has a chance to see the (mostly redundant) messages or not?

This is not a viable idea, I am afraid to tell you. And I am just relaying the message, so don't harm me.

[olfek]

@dscho ---

specific to certain Git commands

So applications sometimes read output intended for interactive sessions?

and isn't parsed before the code location where the message would practically need to be displayed

So parse it before that code location then.

such a disruptive message

I think this is subjective, I don't think it's disruptive at all, remember there's git config to make everyone happy.

So you would like to display this all the time (and perform the prerequisite update check all the time, too), regardless whether the command was called interactively or not?

Not all the time, once every X hours or days is fine, same cadence as what exists now for the windows notification, and only when called interactively.

you want each and every one of those to print that message

No, just the main process, at the entry point.

[dscho]

I see you really try hard to save your idea, but it simply does not work.

[olfek]

@dscho ---

If I had any kind of influence over this project I would prove you wrong, but alas.

[dscho]

@olfek you could gain influence. But not by talking, and continuing to just talk, and suggest what others could do in order to implement your wish.

[olfek]

@dscho ---

Here's an example of an NPM package that provides this functionality to Node CLI apps.

https://www.npmjs.com/package/update-notifier

Sure, I could stop talking and I could submit a PR, but based on current sentiment, it'll go straight into the trash, so why waste my time?

Anyway, going back to the original problem here, since you so strongly oppose CLI notifications, a solution is to just show an update popup window, even in DND 😬

[dscho]

I would prove you wrong, but alas.

You could still try that and impress me.