amend! ci(ui-tests): enforce a sensible timeout

ci(ui-tests): enforce a sensible timeout

The `ui-tests` job currently takes around half a minute to a minute.
Therefore it is quite alarming when the job times out after the default
of 6h. Let's let it time out after 10 minutes (we can always increase it
when more tests are added).

Unfortunately, this changes the failure mode and `cancelled()` will no
longer return `true`. Which means that the existing `if:` clauses have
to be adapted for showing the logs and taking & uploading a screenshot.
While thinking of the logs, I realized that it would be good also to
have them in the case that the run succeeded, so let's always show them.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

.github/workflows/ui-tests.yml

@@ -121,12 +121,12 @@ jobs:
           if ($p2.ExitCode -ne 0) { echo "::error::Ctrl+C Test failed!" } else { echo "::notice::Ctrl+C Test log" }
           type ctrl-c.log
           if ($p.ExitCode -ne 0) { exit 1 }
-      - name: Show logs, if canceled
-        if: cancelled()
+      - name: Show logs
+        if: always()
         run: type bg-hook.log; type ctrl-c.log
       - name: Take screenshot, if canceled
         id: take-screenshot
-        if: cancelled() && steps.ui-tests.conclusion == 'cancelled'
+        if: cancelled() || failure()
         shell: pwsh
         run: |
           [Reflection.Assembly]::LoadWithPartialName("System.Drawing")
@@ -144,7 +144,7 @@ jobs:
           screenshot $bounds "screenshot.png"
       - name: Upload screenshot, if taken
         uses: actions/upload-artifact@v4
-        if: steps.take-screenshot.conclusion == 'success'
+        if: always() && steps.take-screenshot.conclusion == 'success'
         with:
           name: screenshot
           path: screenshot.png