Skip to content

Commit a5073eb

Browse files
committed
Revert "Cygwin: console: Fix tcsetattr which was broken sinse cygwin 3.5.5"
It was reported in git-for-windows/git#5688 (comment) that a lengthy clone via SSH cannot be interrupted via Ctrl+C anymore. This can be reproduced by cloning a large-ish repository via SSH, e.g. git clone git@github:SFML/SFML in PowerShell in a Windows Terminal and then trying to interrupt it via Ctrl+C. This will not work, the SSH process will continue to do what it wants to do and finish as if the user had never indicated that they wanted the process to stop. I've bisected this down to d9ebf01 (Cygwin: console: Fix tcsetattr which was broken sinse cygwin 3.5.5, 2025-04-08), and while it is quite clear that reverting it (which this here patch does) helps fixing the Ctrl+C problem (but is not sufficient), it is unclear what the correct solution is. Nevertheless, not being able to interrupt SSH-based clones seems to be much worse than reintroducing the bug that has been with us since Cygwin runtime v3.5.5 that was purportedly fixed by said commit. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent fe587e1 commit a5073eb

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

winsup/cygwin/fhandler/console.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2228,8 +2228,6 @@ int
22282228
fhandler_console::tcsetattr (int a, struct termios const *t)
22292229
{
22302230
get_ttyp ()->ti = *t;
2231-
set_input_mode (tty::cygwin, t, &handle_set);
2232-
set_output_mode (tty::cygwin, t, &handle_set);
22332231
return 0;
22342232
}
22352233

0 commit comments

Comments
 (0)