Commit a5073eb
committed
Revert "Cygwin: console: Fix tcsetattr which was broken sinse cygwin 3.5.5"
It was reported in
git-for-windows/git#5688 (comment)
that a lengthy clone via SSH cannot be interrupted via Ctrl+C anymore.
This can be reproduced by cloning a large-ish repository via SSH, e.g.
git clone git@github:SFML/SFML
in PowerShell in a Windows Terminal and then trying to interrupt it via
Ctrl+C. This will not work, the SSH process will continue to do what it
wants to do and finish as if the user had never indicated that they
wanted the process to stop.
I've bisected this down to d9ebf01 (Cygwin: console: Fix tcsetattr
which was broken sinse cygwin 3.5.5, 2025-04-08), and while it is quite
clear that reverting it (which this here patch does) helps fixing the
Ctrl+C problem (but is not sufficient), it is unclear what the correct
solution is. Nevertheless, not being able to interrupt SSH-based clones
seems to be much worse than reintroducing the bug that has been with us
since Cygwin runtime v3.5.5 that was purportedly fixed by said commit.
Signed-off-by: Johannes Schindelin <[email protected]>1 parent fe587e1 commit a5073eb
1 file changed
+0
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2228 | 2228 | | |
2229 | 2229 | | |
2230 | 2230 | | |
2231 | | - | |
2232 | | - | |
2233 | 2231 | | |
2234 | 2232 | | |
2235 | 2233 | | |
| |||
0 commit comments