Merge pull request #261 from dscho/more-eslint

ci: run ESLint

Author: dscho

.eslintrc.json

@@ -1,26 +1,29 @@
 {
-    "plugins": ["jest", "@typescript-eslint"],
+    "env": {
+      "es6": true,
+      "jest": true,
+      "jest/globals": true,
+      "node": true
+    },
     "extends": ["plugin:github/recommended"],
     "parser": "@typescript-eslint/parser",
     "parserOptions": {
       "ecmaVersion": 9,
-      "sourceType": "module",
-      "project": "./tsconfig.json"
+      "project": "./tsconfig.json",
+      "sourceType": "module"
     },
+    "plugins": [
+       "@typescript-eslint",
+       "anti-trojan-source",
+       "jest"
+    ],
     "rules": {
-      "eslint-comments/no-use": "off",
-      "filenames/match-regex": [2, "^[a-z_]+(\\.test)?$", true],
-      "import/no-namespace": "off",
-      "no-unused-vars": "off",
-      "@typescript-eslint/no-unused-vars": "off",
-      "@typescript-eslint/explicit-member-accessibility": ["error", {"accessibility": "no-public"}],
-      "@typescript-eslint/no-require-imports": "error",
       "@typescript-eslint/array-type": "error",
       "@typescript-eslint/await-thenable": "error",
       "@typescript-eslint/ban-ts-comment": "error",
-      "camelcase": "off",
       "@typescript-eslint/consistent-type-assertions": "error",
       "@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}],
+      "@typescript-eslint/explicit-member-accessibility": ["error", {"accessibility": "no-public"}],
       "@typescript-eslint/func-call-spacing": ["error", "never"],
       "@typescript-eslint/no-array-constructor": "error",
       "@typescript-eslint/no-empty-interface": "error",
@@ -31,8 +34,10 @@
       "@typescript-eslint/no-misused-new": "error",
       "@typescript-eslint/no-namespace": "error",
       "@typescript-eslint/no-non-null-assertion": "warn",
+      "@typescript-eslint/no-require-imports": "error",
       "@typescript-eslint/no-unnecessary-qualifier": "error",
       "@typescript-eslint/no-unnecessary-type-assertion": "error",
+      "@typescript-eslint/no-unused-vars": "off",
       "@typescript-eslint/no-useless-constructor": "error",
       "@typescript-eslint/no-var-requires": "error",
       "@typescript-eslint/prefer-for-of": "warn",
@@ -42,16 +47,16 @@
       "@typescript-eslint/promise-function-async": "error",
       "@typescript-eslint/require-array-sort-compare": "error",
       "@typescript-eslint/restrict-plus-operands": "error",
-      "semi": "off",
       "@typescript-eslint/semi": ["error", "never"],
       "@typescript-eslint/type-annotation-spacing": "error",
       "@typescript-eslint/unbound-method": "error",
-      "i18n-text/no-en": "off"
-    },
-    "env": {
-      "node": true,
-      "jest": true,
-      "es6": true,
-      "jest/globals": true
+      "anti-trojan-source/no-bidi": "error",
+      "camelcase": "off",
+      "eslint-comments/no-use": "off",
+      "filenames/match-regex": [2, "^[a-z_]+(\\.test|\\.d)?$", true],
+      "i18n-text/no-en": "off",
+      "import/no-namespace": "off",
+      "no-unused-vars": "off",
+      "semi": "off"
     }
-  }
+  }

.github/workflows/test.yml

@@ -15,6 +15,8 @@ jobs:
       - uses: actions/checkout@v2
       - run: npm ci
       - run: npm run build
+      - run: npm run lint
+      - run: npm run format && git diff-files
       - run: npm run test
       - run: npm run package
       - name: Verify that `dist/index.js` is up to date