release: 1.3.0 (#258)

Author: devxb

src/main/kotlin/org/gitanimals/core/advice/GlobalExceptionHandler.kt

@@ -1,15 +1,19 @@
 package org.gitanimals.core.advice
 
 import org.gitanimals.core.ErrorResponse
+import org.slf4j.LoggerFactory
 import org.springframework.http.HttpStatus
 import org.springframework.http.ResponseEntity
 import org.springframework.web.bind.MissingRequestHeaderException
 import org.springframework.web.bind.annotation.ExceptionHandler
+import org.springframework.web.bind.annotation.ResponseStatus
 import org.springframework.web.bind.annotation.RestControllerAdvice
 
 @RestControllerAdvice
 class GlobalExceptionHandler {
 
+    private val logger = LoggerFactory.getLogger(this::class.simpleName)
+
     @ExceptionHandler(MissingRequestHeaderException::class)
     fun handleMissingRequestHeaderException(exception: MissingRequestHeaderException): ResponseEntity<ErrorResponse> {
         if (exception.headerName == "Authorization") {
@@ -19,4 +23,11 @@ class GlobalExceptionHandler {
 
         return ResponseEntity.badRequest().body(ErrorResponse.from(exception))
     }
+
+    @ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
+    @ExceptionHandler(IllegalStateException::class)
+    fun handleIllegalStateException(exception: IllegalStateException): ErrorResponse {
+        logger.error(exception.message, exception)
+        return ErrorResponse.from(exception)
+    }
 }

src/main/kotlin/org/gitanimals/guild/controller/GuildController.kt

@@ -1,5 +1,6 @@
 package org.gitanimals.guild.controller
 
+import jakarta.servlet.http.HttpServletResponse
 import org.gitanimals.core.AuthorizationException
 import org.gitanimals.core.ErrorResponse
 import org.gitanimals.core.FieldType
@@ -147,20 +148,28 @@ class GuildController(
     @GetMapping(value = ["/guilds/{guildId}/draw"], produces = ["image/svg+xml"])
     fun draw(
         @PathVariable("guildId") guildId: Long,
-    ) = drawGuildFacade.drawGuild(guildId)
+        response: HttpServletResponse,
+    ): String {
+        response.cacheControl(3600)
+        return drawGuildFacade.drawGuild(guildId)
+    }
 
     @ExceptionHandler(IllegalArgumentException::class)
     @ResponseStatus(HttpStatus.BAD_REQUEST)
     fun handleIllegalArgumentException(exception: IllegalArgumentException): ErrorResponse =
         ErrorResponse.from(exception)
 
-    @ExceptionHandler(IllegalStateException::class)
-    @ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
-    fun handleIllegalArgumentException(exception: IllegalStateException): ErrorResponse =
-        ErrorResponse.from(exception)
-
     @ExceptionHandler(AuthorizationException::class)
     @ResponseStatus(HttpStatus.UNAUTHORIZED)
     fun handleAuthorizationException(exception: AuthorizationException): ErrorResponse =
         ErrorResponse.from(exception)
+
+    private fun HttpServletResponse.cacheControl(maxAgeSeconds: Int): HttpServletResponse {
+        this.setHeader(
+            HttpHeaders.CACHE_CONTROL,
+            "no-cache, no-store, must-revalidate, max-age=$maxAgeSeconds"
+        )
+        this.setHeader(HttpHeaders.PRAGMA, "no-cache")
+        return this
+    }
 }

src/main/kotlin/org/gitanimals/render/controller/AnimationController.kt

@@ -54,7 +54,7 @@ class AnimationController(
         return username.substring(start, end)
     }
 
-    fun HttpServletResponse.cacheControl(maxAgeSeconds: Int): HttpServletResponse {
+    private fun HttpServletResponse.cacheControl(maxAgeSeconds: Int): HttpServletResponse {
         this.setHeader(
             HttpHeaders.CACHE_CONTROL,
             "no-cache, no-store, must-revalidate, max-age=$maxAgeSeconds"

src/main/kotlin/org/gitanimals/render/controller/BackgroundController.kt

@@ -45,11 +45,6 @@ class BackgroundController(
         @RequestParam(name = "name") name: String,
     ) = userFacade.deleteField(token, FieldType.valueOf(name.uppercase()))
 
-    @ExceptionHandler(IllegalStateException::class)
-    @ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
-    fun handleIllegalArgumentException(exception: IllegalStateException): ErrorResponse =
-        ErrorResponse.from(exception)
-
     @ExceptionHandler(IllegalArgumentException::class)
     @ResponseStatus(HttpStatus.BAD_REQUEST)
     fun handleIllegalArgumentException(illegalArgumentException: IllegalArgumentException): ErrorResponse =

src/main/kotlin/org/gitanimals/render/controller/PersonaController.kt

@@ -82,11 +82,6 @@ class PersonaController(
     fun handleIllegalArgumentException(exception: IllegalArgumentException): ErrorResponse =
         ErrorResponse.from(exception)
 
-    @ExceptionHandler(IllegalStateException::class)
-    @ResponseStatus(HttpStatus.INTERNAL_SERVER_ERROR)
-    fun handleIllegalArgumentException(exception: IllegalStateException): ErrorResponse =
-        ErrorResponse.from(exception)
-
     @ExceptionHandler(AuthorizationException::class)
     @ResponseStatus(HttpStatus.UNAUTHORIZED)
     fun handleAuthorizationException(exception: AuthorizationException): ErrorResponse =