Skip to content

Commit 36bc050

Browse files
committed
test: 실패하는 테스트들을 수정한다
1 parent 70de7d6 commit 36bc050

File tree

5 files changed

+19
-4
lines changed

5 files changed

+19
-4
lines changed

src/main/kotlin/org/gitanimals/core/clock.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,6 @@ fun instant() = Instant.now(clock)
1111

1212
fun Instant.toZonedDateTime() = ZonedDateTime.ofInstant(this, clock.zone)
1313

14+
fun Instant.toZonedDateTime(zoneId: ZoneId) = ZonedDateTime.ofInstant(this, zoneId)
15+
1416
fun Instant.toKr() = ZonedDateTime.ofInstant(this, ZoneId.of("Asia/Seoul"))

src/main/kotlin/org/gitanimals/render/domain/User.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class User(
104104

105105
@JsonIgnore
106106
fun isContributionUpdatedBeforeOneHour(): Boolean {
107-
val currentYear = ZonedDateTime.now(ZoneId.of("UTC")).year
107+
val currentYear = instant().toZonedDateTime(ZoneId.of("UTC")).year
108108
val currentYearContribution =
109109
contributions.firstOrNull { it.year == currentYear } ?: return true
110110

src/test/kotlin/org/gitanimals/guild/app/CreateGuildFacadeTest.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import io.kotest.core.annotation.DisplayName
88
import io.kotest.core.spec.style.DescribeSpec
99
import io.mockk.every
1010
import org.gitanimals.core.FieldType
11+
import org.gitanimals.core.IdGenerator
12+
import org.gitanimals.core.filter.MDCFilter.Companion.TRACE_ID
1113
import org.gitanimals.guild.app.request.CreateGuildRequest
1214
import org.gitanimals.guild.domain.GuildIcons
1315
import org.gitanimals.guild.domain.GuildRepository
@@ -16,6 +18,7 @@ import org.gitanimals.guild.supports.RedisContainer
1618
import org.gitanimals.guild.supports.GuildSagaCapture
1719
import org.gitanimals.guild.supports.MockApiConfiguration
1820
import org.rooftop.netx.meta.EnableSaga
21+
import org.slf4j.MDC
1922
import org.springframework.boot.actuate.autoconfigure.wavefront.WavefrontProperties.Application
2023
import org.springframework.boot.autoconfigure.domain.EntityScan
2124
import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest
@@ -50,6 +53,7 @@ internal class CreateGuildFacadeTest(
5053
beforeEach {
5154
guildSagaCapture.clear()
5255
guildRepository.deleteAll()
56+
MDC.put(TRACE_ID, IdGenerator.generate().toString())
5357
}
5458

5559
describe("createGuild 메소드는") {
@@ -118,7 +122,7 @@ internal class CreateGuildFacadeTest(
118122
private val poolIdentityUserResponse = IdentityApi.UserResponse(
119123
id = "1",
120124
username = "devxb",
121-
points = "29999",
125+
points = "0",
122126
profileImage = "https://gitanimals.org"
123127
)
124128

src/test/kotlin/org/gitanimals/guild/domain/GuildServiceTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import org.gitanimals.core.FieldType
99
import org.gitanimals.core.PersonaType
1010
import org.gitanimals.guild.domain.GuildService.Companion.loadMembers
1111
import org.gitanimals.guild.domain.GuildService.Companion.loadWaitMembers
12+
import org.gitanimals.guild.domain.extension.GuildFieldTypeExtension.isGuildField
1213
import org.gitanimals.guild.domain.request.CreateLeaderRequest
1314
import org.springframework.boot.autoconfigure.domain.EntityScan
1415
import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest
@@ -34,7 +35,7 @@ internal class GuildServiceTest(
3435
val guildIcon = GuildIcons.CAT.getImagePath()
3536
val title = "guildTitle"
3637
val body = "guildBody"
37-
val farmType = FieldType.LOGO_SHOWING
38+
val farmType = FieldType.entries.first { it.isGuildField() }
3839
val leaderRequest = CreateLeaderRequest(
3940
userId = 1L,
4041
name = "devxb",

src/test/kotlin/org/gitanimals/render/domain/UserTest.kt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import io.kotest.core.spec.style.DescribeSpec
77
import io.kotest.matchers.equals.shouldBeEqual
88
import io.kotest.matchers.nulls.shouldNotBeNull
99
import org.gitanimals.core.PersonaType
10+
import org.gitanimals.core.instant
11+
import org.gitanimals.core.toZonedDateTime
1012
import org.gitanimals.render.domain.event.PersonaDeleted
1113
import org.gitanimals.render.domain.listeners.DomainEventPublisher
1214
import org.gitanimals.render.domain.value.Contribution
@@ -79,7 +81,13 @@ internal class UserTest(
7981

8082
context("user의 contribution이 업데이트 된지 1시간이 지나지 않았을 경우,") {
8183
val user = user(
82-
contributions = mutableListOf(Contribution(2024, 0, Instant.now()))
84+
contributions = mutableListOf(
85+
Contribution(
86+
instant().toZonedDateTime().year,
87+
0,
88+
instant(),
89+
)
90+
)
8391
)
8492
it("false를 반환한다.") {
8593
user.isContributionUpdatedBeforeOneHour() shouldBeEqual false

0 commit comments

Comments
 (0)