Skip to content

Commit a69dccc

Browse files
committed
refactor: rank 쿼리가 1부터 시작되도록 수정한다
1 parent 07adc37 commit a69dccc

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/kotlin/org/gitanimals/rank/app/GetRankByUsernameFacade.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class GetRankByUsernameFacade(
2525

2626
return RankResponse(
2727
id = userContributionRank.userId.toString(),
28-
rank = rankQueryResponse.rank,
28+
rank = rankQueryResponse.rank + 1,
2929
image = userContributionRank.image,
3030
name = userContributionRank.username,
3131
contributions = userContributionRank.weeklyContributions,

src/main/kotlin/org/gitanimals/rank/app/RankQueryFacade.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class RankQueryFacade(
2727
): List<RankResponse> {
2828
require(size > 1) { "Size must be lager than 1. size: $size" }
2929
require(size <= 20) { "Maximum request size is 20. size: $size" }
30-
require(rank > 0) { "Rank must be larger than 0. rank: $rank" }
30+
require(rank >= 0) { "Rank must be larger than 0. rank: $rank" }
3131

3232
val rankWithIds = rankQueryRepository.findAllRank(
3333
rankStartedAt = rank,
@@ -38,7 +38,7 @@ class RankQueryFacade(
3838
return when (rankType) {
3939
WEEKLY_GUILD_CONTRIBUTIONS -> guildContributionRankService.findAllByRankIds(rankWithIds)
4040
WEEKLY_USER_CONTRIBUTIONS -> userContributionRankService.findAllByRankIds(rankWithIds)
41-
}.map { it.copy(contributions = max(0, it.contributions)) }
41+
}.map { it.copy(rank = it.rank + 1, contributions = max(0, it.contributions)) }
4242
}
4343

4444
@Cacheable(cacheNames = ["rankTotalCountCacheManager"], key = "#rankType")

0 commit comments

Comments
 (0)