Skip to content

Commit d320d6a

Browse files
authored
Fix missing commit in hp-update-remote and hp-populate-remote (#175)
# Exercise Review ## Exercise Discussion Fix #174 ## Checklist - [ ] If you require a new remote repository on the `Git-Mastery` organization, have you [created a request](https://github.com/git-mastery/exercises/issues/new?template=request_exercise_repository.md) for it? - [ ] Have you written unit tests using [`repo-smith`](https://github.com/git-mastery/repo-smith) to validate the exercise grading scheme? - [X] Have you tested the download script using `test-download.sh`? - [X] Have you verified that this exercise does not already exist or is not currently in review? - [ ] Did you introduce a new grading mechanism that should belong to [`git-autograder`](https://github.com/git-mastery/git-autograder)? - [ ] Did you introduce a new dependency that should belong to [`app`](https://github.com/git-mastery/app)?
1 parent 0481718 commit d320d6a

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

hands_on/populate_remote.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ def _setup_local_repository(verbose: bool):
3636
""",
3737
)
3838
add(["fruits.txt"], verbose)
39+
commit("Add fruits.txt", verbose)
3940

4041
append_to_file("fruits.txt", "figs")
4142
add(["fruits.txt"], verbose)

hands_on/update_remote.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,11 @@
1818

1919
def download(verbose: bool):
2020
username = get_github_username(verbose)
21+
2122
os.makedirs("things")
2223
os.chdir("things")
2324
init(verbose)
25+
2426
create_or_update_file(
2527
"fruits.txt",
2628
"""
@@ -31,9 +33,12 @@ def download(verbose: bool):
3133
""",
3234
)
3335
add(["fruits.txt"], verbose)
36+
commit("Add fruits.txt", verbose)
37+
3438
append_to_file("fruits.txt", "figs")
3539
add(["fruits.txt"], verbose)
3640
commit("Insert figs into fruits.txt", verbose)
41+
3742
create_or_update_file(
3843
"colours.txt",
3944
"""
@@ -46,8 +51,10 @@ def download(verbose: bool):
4651
a file for shapes
4752
""",
4853
)
54+
4955
add(["colours.txt", "shapes.txt"], verbose)
5056
commit("Add colours.txt, shapes.txt", verbose)
57+
5158
repo_check = has_repo(REPO_NAME, False, verbose)
5259

5360
if repo_check:

0 commit comments

Comments
 (0)