[ignoring-somethings] Add more verifications

Author: woojiahao

ignoring_somethings/tests/specs/base.yml

@@ -0,0 +1,16 @@
+initialization:
+  steps:
+    - type: commit
+      empty: true
+      message: Empty commit
+      id: start
+    - type: new-file
+      filename: .gitignore
+      contents: |
+        many/*
+        why_am_i_hidden.txt
+    - type: add
+      files:
+        - .gitignore
+    - type: commit
+      message: Add .gitignore

ignoring_somethings/tests/specs/no_change.yml

@@ -0,0 +1,18 @@
+initialization:
+  steps:
+    - type: commit
+      empty: true
+      message: Empty commit
+      id: start
+    - type: new-file
+      filename: .gitignore
+      contents: |
+        many/*
+        !many/file22.txt
+        ignore_me.txt
+        this/**/runaway.txt
+    - type: add
+      files:
+        - .gitignore
+    - type: commit
+      message: Add .gitignore

ignoring_somethings/tests/specs/valid.yml

@@ -1,12 +1,36 @@
-from git_autograder import GitAutograderTestLoader
+from git_autograder import GitAutograderStatus, GitAutograderTestLoader, assert_output
 
-from ..verify import verify
+from ..verify import (
+    NOT_IGNORING_IGNORE_ME,
+    NOT_IGNORING_RUNAWAY,
+    STILL_HIDING,
+    STILL_IGNORING_FILE_22,
+    verify,
+)
 
 REPOSITORY_NAME = "ignoring-somethings"
 
 loader = GitAutograderTestLoader(__file__, REPOSITORY_NAME, verify)
 
 
-def test():
-    with loader.load("specs/base.yml", "start"):
-        pass
+def test_valid():
+    with loader.load("specs/valid.yml", "start") as output:
+        assert_output(
+            output,
+            GitAutograderStatus.SUCCESSFUL,
+            ["Great work using .gitignore!"],
+        )
+
+
+def test_no_change():
+    with loader.load("specs/no_change.yml", "start") as output:
+        assert_output(
+            output,
+            GitAutograderStatus.UNSUCCESSFUL,
+            [
+                STILL_IGNORING_FILE_22,
+                STILL_HIDING,
+                NOT_IGNORING_IGNORE_ME,
+                NOT_IGNORING_RUNAWAY,
+            ],
+        )

ignoring_somethings/tests/test_verify.py

@@ -1,3 +1,4 @@
+import os
 from typing import List
 
 from git_autograder import GitAutograderOutput, GitAutograderRepo, GitAutograderStatus
@@ -25,13 +26,12 @@ def verify(repo: GitAutograderRepo) -> GitAutograderOutput:
     main_branch.latest_commit.checkout()
 
     # Read the file and parse it
-    with open(".gitignore", "r") as gitignore_file:
+    with open(os.path.join(repo.repo_path, ".gitignore"), "r") as gitignore_file:
         lines = [
             line.strip() for line in gitignore_file.readlines() if line.strip() != ""
         ]
 
     comments: List[str] = []
-    print(lines)
     if "!many/file22.txt" not in lines:
         comments.append(STILL_IGNORING_FILE_22)