Test-drive Tour 2

[damithc]

Similar to #154
Tour is at https://git-mastery.github.io/lessons/trail/backingUpOnCloud/

[jiaxinnns]

Test Report

• OS tested: MacOS
• Did you use CLI or Sourcetree? CLI

Summary

T2L3

Submitting an incorrect URL (as long as it begins with the correct URL) causes verification to succeed.

T2L5

Instructions reference the master branch, but GitHub automatically sets the default branch to main when the remote is created.

The output of git log --oneline --graph does not match the expected output shown.

T2L6

The instructions say to download hp-ignore-files but the correct hands-on name is hp-ignore-file

The instructions say to download ignoring-something but the correct exercise name is ignoring-somethings

[jovnc]

Thank you @jiaxinnns for the comprehensive testing! I'll add the relevant issues and address them accordingly for those bugs related to git-mastery app/exercises.

#170

Update: fixed the issue and verified its working as expected now

[jovnc]

@damithc For the issues related to T2L6, which naming should we follow?

• hp-ignore-file or hp-ignore-files
• ignoring-something or ignoring-somethings

[damithc]

@damithc For the issues related to T2L6, which naming should we follow?

• hp-ignore-file or hp-ignore-files

@jovnc the latter is more appropriate but given the .py file is hp-ignore-file.py, I've changed the site to use the same.

• ignoring-something or ignoring-somethings

Fixed. Should be ignoring-somethings.

[damithc]

Thanks for testing this, @jiaxinnns

Instructions reference the master branch, but GitHub automatically sets the default branch to main when the remote is created.

The output of `git log --oneline --graph` does not match the expected output shown.

My guess is you've configured your local Git to use main as the default branch. Can you check? If not, you may have initialised the repo when you created the empty repo in GitHub. If you followed the settings given below, there will be no default branch set in GitHub, as no repo is created.

Not responding the other comments as @jovnc followed up on them already. Again, thanks to both of you for the help.

[SAN-MUYUN]

OS: Windows 11
Terminal: Git bash
Git CLI was used

Overall, the instructions are clear and concise. The naming of the hands-on practice and exercise are fixed and working fine.

T2L5 hp-populate-remote

I am also facing the issue where the output of git log does not match the revision graph provided as mentioned by @jiaxinnns . From the code, it seems like there are only 2 commits created in the sandbox, rather than 3. If the student is using local repo things since T1L5, then the provided revision tree will match. Otherwise, if the student is starting fresh using the sandbox, he/she will be missing the Add fruits.txt commit node. Similar for hp-update-remote

[jovnc]

I am also facing the issue where the output of git log does not match the revision graph provided as mentioned by @jiaxinnns .

Thanks @SAN-MUYUN, I'll address the comments as the issue likely lies with git-mastery itself. I'll open the PR and resolve them soon. No action needed from Prof Damith.

#174

[jovnc]

Test Report

• OS tested: MacOS
• Did you use CLI or Sourcetree? CLI

Summary

Overall, I have tested that all exercises and hands-on works as expected (passes tests as expected, and fails tests and expected, and the download logic is correct).

T2L1

LGTM

T2L2

LGTM

T2L3

The image can be updated, or we can inform users that there is a change to the Github UI, as there is now a new section for copilot (which they should leave empty).

T2L4

LGTM

T2L5

hp-populate-remote uses master as default branch, but gitmastery downloads as main branch as default now. This should be resolved with #178. Need to recheck this later on.

Seems like there are also some references to main branch here as well, once we have fully migrated to master as default, we will need to change this.

T2L6

LGTM