Drag and drop to welcome window (#571)

Welcome Window accepts drag and drop of folders with git repos

- Main GitUp icon is currently taking the drag and drop and needs to have it's drag types removed. Follow up with future commit.

Author: lolgear

GitUp/Application/AppDelegate.m

@@ -40,32 +40,6 @@
 #define kToolInstallPath @"/usr/local/bin/" kToolName
 
 @interface AppDelegate () <NSUserNotificationCenterDelegate, SUUpdaterDelegate>
-- (IBAction)closeWelcomeWindow:(id)sender;
-@end
-
-@interface WelcomeWindow : NSWindow
-@end
-
-@implementation WelcomeWindow
-
-- (void)awakeFromNib {
-  self.opaque = NO;
-  self.backgroundColor = [NSColor clearColor];
-  self.movableByWindowBackground = YES;
-}
-
-- (BOOL)validateMenuItem:(NSMenuItem*)menuItem {
-  return menuItem.action == @selector(performClose:) ? YES : [super validateMenuItem:menuItem];
-}
-
-- (void)performClose:(id)sender {
-  [[AppDelegate sharedDelegate] closeWelcomeWindow:sender];
-}
-
-- (BOOL)canBecomeKeyWindow {
-  return YES;
-}
-
 @end
 
 @implementation AppDelegate {

GitUp/Application/Base.lproj/MainMenu.xib

@@ -1140,7 +1140,7 @@ UI design by Wayne Fan</string>
                     <box boxType="custom" borderType="none" borderWidth="0.0" cornerRadius="10" title="Box" titlePosition="noTitle" id="UoN-n1-xSr">
                         <rect key="frame" x="0.0" y="0.0" width="280" height="349"/>
                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
-                        <view key="contentView" id="UVs-2r-EAT">
+                        <view key="contentView" id="UVs-2r-EAT" customClass="WelcomeWindowView">
                             <rect key="frame" x="0.0" y="0.0" width="280" height="349"/>
                             <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
                             <subviews>
@@ -1284,6 +1284,9 @@ UI design by Wayne Fan</string>
                     </box>
                 </subviews>
             </view>
+            <connections>
+                <outlet property="destinationView" destination="UVs-2r-EAT" id="AvQ-6L-KSz"/>
+            </connections>
             <point key="canvasLocation" x="-252" y="578.5"/>
         </window>
         <userDefaultsController representsSharedInstance="YES" id="AR1-cq-KNa"/>

GitUp/Application/WelcomeWindow.h

@@ -0,0 +1,16 @@
+//
+//  WelcomeWindow.h
+//  Application
+//
+//  Created by Dmitry Lobanov on 10/09/2019.
+//
+
+#import <Cocoa/Cocoa.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface WelcomeWindow : NSWindow
+
+@end
+
+NS_ASSUME_NONNULL_END

GitUp/Application/WelcomeWindow.m

@@ -0,0 +1,134 @@
+//
+//  WelcomeWindow.m
+//  Application
+//
+//  Created by Dmitry Lobanov on 10/09/2019.
+//
+
+#import "WelcomeWindow.h"
+
+#import "AppDelegate.h"
+#import "Document.h"
+
+@interface AppDelegate (WelcomeWindow)
+- (IBAction)closeWelcomeWindow:(id)sender;
+- (void)_openRepositoryWithURL:(NSURL*)url withCloneMode:(CloneMode)cloneMode windowModeID:(WindowModeID)windowModeID;
+@end
+
+@interface WelcomeWindowView : NSView <NSDraggingDestination>
+@property (weak, nonatomic, readonly) AppDelegate *appDelegate;
+@property (assign, nonatomic) BOOL receivingDrag;
+@end
+
+@implementation WelcomeWindowView
+
+#pragma mark - Accessors
+- (AppDelegate *)appDelegate {
+  return [AppDelegate sharedDelegate];
+}
+
+#pragma mark - Setup
+- (void)setup {
+  [self registerForDraggedTypes:@[NSURLPboardType]];
+}
+
+- (void)awakeFromNib {
+  [super awakeFromNib];
+  [self setup];
+}
+
+#pragma mark - Drawing
+- (void)setReceivingDrag:(BOOL)receivingDrag {
+  _receivingDrag = receivingDrag;
+  [self setNeedsDisplay:YES];
+}
+
+- (void)drawRect:(NSRect)dirtyRect {
+  if (self.receivingDrag) {
+    [NSColor.selectedControlColor set];
+    NSBezierPath *path = [NSBezierPath bezierPathWithRoundedRect:self.bounds xRadius:10 yRadius:10];
+    path.lineWidth = 5;
+    [path stroke];
+  }
+}
+
+#pragma mark - Dragging Data Extraction
+- (BOOL)canDragItem:(id<NSDraggingInfo>)sender {
+  return [self draggingItems:sender].count > 0;
+}
+
+- (NSArray <NSURL *>*)draggingItems:(id<NSDraggingInfo>)sender {
+  return [[sender draggingPasteboard] readObjectsForClasses:@[NSURL.class] options:nil];
+}
+
+#pragma mark - NSDraggingDestination
+- (NSDragOperation)draggingEntered:(id<NSDraggingInfo>)sender {
+  BOOL canDragItem = [self canDragItem:sender];
+  self.receivingDrag = canDragItem;
+  return canDragItem ? NSDragOperationCopy :  NSDragOperationNone;
+}
+
+- (void)draggingEnded:(id<NSDraggingInfo>)sender {
+  self.receivingDrag = NO;
+}
+
+- (void)draggingExited:(id<NSDraggingInfo>)sender {
+  self.receivingDrag = NO;
+}
+
+- (BOOL)prepareForDragOperation:(id<NSDraggingInfo>)sender {
+  return [self canDragItem:sender];
+}
+
+- (BOOL)performDragOperation:(id<NSDraggingInfo>)sender {
+  self.receivingDrag = NO;
+  
+  NSURL *first = [self draggingItems:sender].firstObject;
+  [self.appDelegate _openRepositoryWithURL:first withCloneMode:kCloneMode_None windowModeID:NSNotFound];
+  
+  return YES;
+}
+
+- (void)concludeDragOperation:(id<NSDraggingInfo>)sender {
+  // necessary cleanup?
+}
+@end
+
+@interface WelcomeWindow ()
+@property (weak, nonatomic, readonly) AppDelegate *appDelegate;
+@property (weak, nonatomic, readwrite) IBOutlet WelcomeWindowView *destinationView;
+@end
+
+@implementation WelcomeWindow
+
+#pragma mark - Accessors
+- (AppDelegate *)appDelegate {
+  return [AppDelegate sharedDelegate];
+}
+
+#pragma mark - Setup
+- (void)setup {
+  self.opaque = NO;
+  self.backgroundColor = [NSColor clearColor];
+  self.movableByWindowBackground = YES;
+}
+
+- (void)awakeFromNib {
+  [self setup];
+}
+
+#pragma mark - Actions
+- (BOOL)validateMenuItem:(NSMenuItem*)menuItem {
+  return menuItem.action == @selector(performClose:) ? YES : [super validateMenuItem:menuItem];
+}
+
+- (void)performClose:(id)sender {
+  [self.appDelegate closeWelcomeWindow:sender];
+}
+
+#pragma mark - Window
+- (BOOL)canBecomeKeyWindow {
+  return YES;
+}
+
+@end

GitUp/GitUp.xcodeproj/project.pbxproj

@@ -7,6 +7,7 @@
 	objects = {
 
 /* Begin PBXBuildFile section */
+		0AD4625B232711B000BE28D1 /* WelcomeWindow.m in Sources */ = {isa = PBXBuildFile; fileRef = 0AD4625A232711B000BE28D1 /* WelcomeWindow.m */; };
 		0AE7F5F12312C1B000B06050 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 0AE7F5ED2312C1B000B06050 /* InfoPlist.strings */; };
 		165C32B61B95739700D2F894 /* QuartzCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 165C32B51B95739700D2F894 /* QuartzCore.framework */; };
 		31CD50E3203E2E2800360B3A /* ToolbarItemWrapperView.m in Sources */ = {isa = PBXBuildFile; fileRef = 31CD50E2203E2E2800360B3A /* ToolbarItemWrapperView.m */; };
@@ -107,6 +108,8 @@
 /* End PBXCopyFilesBuildPhase section */
 
 /* Begin PBXFileReference section */
+		0AD46259232711B000BE28D1 /* WelcomeWindow.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WelcomeWindow.h; sourceTree = "<group>"; };
+		0AD4625A232711B000BE28D1 /* WelcomeWindow.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = WelcomeWindow.m; sourceTree = "<group>"; };
 		0AE7F5EE2312C1B000B06050 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = "<group>"; };
 		165C32B51B95739700D2F894 /* QuartzCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = QuartzCore.framework; path = System/Library/Frameworks/QuartzCore.framework; sourceTree = SDKROOT; };
 		31CD50E1203E2E2800360B3A /* ToolbarItemWrapperView.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ToolbarItemWrapperView.h; sourceTree = "<group>"; };
@@ -276,6 +279,8 @@
 				E2C5672C1A6D98BC00ECFE07 /* WindowController.m */,
 				31CD50E1203E2E2800360B3A /* ToolbarItemWrapperView.h */,
 				31CD50E2203E2E2800360B3A /* ToolbarItemWrapperView.m */,
+				0AD46259232711B000BE28D1 /* WelcomeWindow.h */,
+				0AD4625A232711B000BE28D1 /* WelcomeWindow.m */,
 			);
 			path = Application;
 			sourceTree = "<group>";
@@ -432,6 +437,7 @@
 				E2C5672D1A6D98BC00ECFE07 /* WindowController.m in Sources */,
 				E2C338B219F8562F00063D95 /* AppDelegate.m in Sources */,
 				E2C338B719F8562F00063D95 /* Document.m in Sources */,
+				0AD4625B232711B000BE28D1 /* WelcomeWindow.m in Sources */,
 				31CD50E3203E2E2800360B3A /* ToolbarItemWrapperView.m in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;