ci: fixes for fedora

Use fedora's valgrind instead of trying to build our own; omit false
positive leaks in getaddrinfo;

Author: ethomson

ci/docker/fedora

@@ -18,10 +18,12 @@ RUN yum install -y \
 	java-1.8.0-openjdk-headless \
 	sudo \
 	python3 \
+	valgrind \
 	krb5-workstation \
 	krb5-libs \
-    krb5-devel \
-    pcre2-devel \
+	krb5-devel \
+	pcre2-devel \
+	zlib-devel \
 	ninja-build \
 	llhttp-devel
 
@@ -35,18 +37,7 @@ RUN cd /tmp && \
     cd .. && \
     rm -rf libssh2-1.11.0
 
-FROM libssh2 AS valgrind
-RUN cd /tmp && \
-    curl --insecure --location --silent --show-error https://sourceware.org/pub/valgrind/valgrind-3.15.0.tar.bz2 | \
-        tar -xj && \
-    cd valgrind-3.15.0 && \
-    ./configure && \
-    make MAKEFLAGS="-j -l$(grep -c ^processor /proc/cpuinfo)" && \
-    make install && \
-    cd .. && \
-    rm -rf valgrind-3.15.0
-
-FROM valgrind AS adduser
+FROM libssh2 AS adduser
 ARG UID=""
 ARG GID=""
 RUN if [ "${UID}" != "" ]; then USER_ARG="--uid ${UID}"; fi && \

script/valgrind.supp

@@ -80,6 +80,13 @@
 	fun:__check_pf
 }
 
+{
+	ignore-glibc-getaddrinfo-fn
+	Memcheck:Leak
+	...
+	fun:getaddrinfo
+}
+
 {
 	ignore-curl-global-init
 	Memcheck:Leak