aliases: Keep not only anchor but also query when redirecting

dscho · dscho · commit 40fc16d2a8c5 · 2024-09-27T11:26:51.000+02:00
We just fixed a bug where clicking on an operating system button in https://git-scm.com/downloads/guis replaced the URL by an incorrect URL, e.g. https://git-scm.com/download/guis?os=linux instead of https://git-scm.com/downloads/guis?os=linux (note the singular "download" in the incorrect URL). We want to handle such URLs gracefully, though, just in case those links were already shared. Therefore we are about to add aliases, but the way aliases are currently handled loses the `?os=linux` part of the URL, which is rather important. Let's copy that part (which is called `window.location.search` in Javascript) into the new URL in the Javascript part of the redirect page (which is typically taking precedence over the `<meta http-equiv="refresh" ...>` tag). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
diff --git a/layouts/_default/baseof.html b/layouts/_default/baseof.html
@@ -13,7 +13,7 @@
   <meta name="robots" content="noindex">
  </head>
  <body>
-  <script>window.location.replace(document.querySelector("link[rel='canonical']").href + window.location.hash)</script>
+  <script>window.location.replace(document.querySelector("link[rel='canonical']").href + window.location.search + window.location.hash)</script>
   <h1>Redirecting&hellip;</h1>
   <a href="{{ $redirect_to }}">Click here if you are not redirected.</a>
  </body>
diff --git a/layouts/alias.html b/layouts/alias.html
@@ -8,7 +8,7 @@
   <meta name="robots" content="noindex">
  </head>
  <body>
-  <script>window.location.replace(document.querySelector("link[rel='canonical']").href + window.location.hash)</script>
+  <script>window.location.replace(document.querySelector("link[rel='canonical']").href + window.location.search + window.location.hash)</script>
   <h1>Redirecting&hellip;</h1>
   <a href="{{ $redirect_to }}">Click here if you are not redirected.</a>
  </body>
