Skip to content

Commit 4d5ef29

Browse files
committed
dark mode: adjust some border colors
The light mode colors of the borders around e.g. the options of Git commands in their synopsis are unpleasantly bright in dark mode; Let's adjust them to be less sore on the eye. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 3abc6ac commit 4d5ef29

File tree

5 files changed

+20
-5
lines changed

5 files changed

+20
-5
lines changed

assets/sass/application.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ code {
3636

3737
pre {
3838
background-color: var(--main-bg);
39-
border: solid 1px #efeee6;
39+
border: solid 1px var(--pre-border);
4040
border-radius: 3px;
4141
color: var(--orange);
4242
display: block;

assets/sass/dark-mode.css

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,17 @@
1414
$base-border-color: #d8d7cf;
1515
$callout-color: #e9e8e0;
1616
$highlight-bg-color: #eee0b5;
17+
$pre-border: #efeee6;
1718
$black-3: #333333;
1819
$main-bg: #fcfcfa;
20+
$main-border: #e2e0d8;
1921
$bg-color: #f0efe7 url($baseurl + "images/bg/body.jpg");
2022
$sidebar-bg-color: #efefe7;
2123
$no-changes-bg-color: #f5f5f3;
2224
$dropdown-active-bg-color: #fff;
2325
$versions-footer-bg-color: #eae9e0;
26+
$search-border: #ceccc5;
27+
$search-focus-border: #007175;
2428

2529
@if $mode == dark {
2630
$orange: #d7834f;
@@ -36,13 +40,17 @@
3640
$base-border-color: #b3b2a7;
3741
$callout-color: #555555;
3842
$highlight-bg-color: #7d724f;
43+
$pre-border: #494945;
3944
$black-3: #cccccc;
4045
$main-bg: #333333;
46+
$main-border: #5e5e5a;
4147
$bg-color: #2a2a2aff;
4248
$sidebar-bg-color: #3d3d3a;
4349
$no-changes-bg-color: #515150;
4450
$dropdown-active-bg-color: #515150;
4551
$versions-footer-bg-color: #1f1f1e;
52+
$search-border: #5e5e5a;
53+
$search-focus-border: #ceccc5;
4654

4755
:root#{$theme} {
4856
div#masthead {
@@ -137,14 +145,18 @@
137145
--base-border-color-lighter-10: #{lighten($base-border-color, 10%)};
138146
--callout-color: #{$callout-color};
139147
--highlight-bg-color: #{$highlight-bg-color};
148+
--pre-border: #{$pre-border};
140149

141150
--black-3: #{$black-3};
142151
--main-bg: #{$main-bg};
152+
--main-border: #{$main-border};
143153
--sidebar-bg-color: #{$sidebar-bg-color};
144154
--bg-color: #{$bg-color};
145155
--no-changes-bg-color: #{$no-changes-bg-color};
146156
--dropdown-active-bg-color: #{$dropdown-active-bg-color};
147157
--versions-footer-bg-color: #{$versions-footer-bg-color};
158+
--search-border: #{$search-border};
159+
--search-focus-border: #{$search-focus-border};
148160
}
149161
}
150162

assets/sass/forms.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
@import "variables";
22
@import "mixins";
3+
@import "dark-mode";
34

45
\::-webkit-input-placeholder {
56
color: #9a9994 !important;
@@ -39,7 +40,7 @@ form#search {
3940
padding-left: 32px;
4041
@include background-image-2x($baseurl + "images/icons/search", 17px, 17px, 10px 50%);
4142
background-color: var(--main-bg) !important;
42-
border: solid 1px #ceccc5;
43+
border: solid 1px var(--search-border);
4344
@include border-radius(20px);
4445
@include box-shadow(inset 0 1px 4px #ddd);
4546

@@ -56,7 +57,7 @@ form#search {
5657
}
5758

5859
&.focus {
59-
border-color: #007175;
60+
border-color: var(--search-focus-border);
6061
background-color: var(--main-bg);
6162
}
6263
}

assets/sass/layout.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
@import "variables";
22
@import "mixins";
3+
@import "dark-mode";
34

45
body {
56
padding: 0;
@@ -41,7 +42,7 @@ aside {
4142
padding: 22px;
4243
margin-bottom: 35px;
4344
background-color: var(--main-bg);
44-
border: solid 1px #e2e0d8;
45+
border: solid 1px var(--main-border);
4546
@include border-radius(5px);
4647

4748
.two-column {

assets/sass/typography.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
@import "variables";
22
@import "mixins";
3+
@import "dark-mode";
34

45
// BODY TEXT
56
// ---------
@@ -261,7 +262,7 @@ code {
261262
font-variant-ligatures: none;
262263
color: var(--orange);
263264
background-color: var(--main-bg);
264-
border: solid 1px #efeee6;
265+
border: solid 1px var(--pre-border);
265266
}
266267

267268
// Quotes

0 commit comments

Comments
 (0)