playwright: verify that URLs with question marks work

Some book sections' titles end in a question mark. In URLs, question
marks are interpreted as the separator between the path part and the
query string. This matters because the book sections' titles are used to
construct their URLs.

We want to follow Postel's Law and accept even URLs with non-URI-encoded
question marks, gracefully redirecting to the correct URL. Add code to
the Playwright-based tests to that extent.

While at it, also verify that the redirection uses proper URI-encoding
for non-ASCII characters; This requires a minor improvement of the
intentionally very simplistic `serve-public.js` script.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

script/serve-public.js

@@ -24,7 +24,7 @@ const mimeTypes = {
 };
 
 const handler = (request, response) => {
-    const pathname = url.parse(request.url).pathname;
+    const pathname = decodeURIComponent(url.parse(request.url).pathname);
     let filename = path.join(basePath, pathname === "/" ? "index.html" : pathname);
 
     let stats = fs.statSync(filename, { throwIfNoEntry: false });

tests/git-scm.spec.js

@@ -193,4 +193,14 @@ test('book', async ({ page }) => {
   await page.getByRole('link', { name: 'Français' }).click()
   await expect(page).toHaveURL(/book\/fr/)
   await expect(page.getByRole('link', { name: 'Démarrage rapide' })).toBeVisible()
+
+  // Navigate to a page whose URL contains a question mark
+  await page.goto(`${url}book/az/v2/Başlanğıc-Git-Nədir?`)
+  if (isRailsApp) {
+    await expect(page).toHaveURL(/book\/az\/v2$/)
+    await page.goto(`${url}book/az/v2/Başlanğıc-Git-Nədir%3F`)
+  } else {
+    await expect(page).toHaveURL(/Ba%C5%9Flan%C4%9F%C4%B1c-Git-N%C9%99dir%3F/)
+  }
+  await expect(page.getByRole('document')).toHaveText(/Snapshot’lar, Fərqlər Yox/)
 })