script/update-docs: use ISO-8601 dates for history #1979
Conversation
|
I know I'm pretty biased, and it's one of my pet peeves. But because we use ISO dates already for the release, I hope this change isn't really controversial:
In my opinion are less confusing for everyone. Having a fully qualified year is just better. |
|
@dscho You're also on this side of the pond, so should we ask someone on the other side to review these changes? |
@To1ne By "someone on the other side", do you refer to people living in the country that puts month before day before year when they write out dates? Sure 😆 Having said that, I don't expect anyone from that part of the world to review any git-scm.com PR any time soon, I haven't seen much in the way of contributions to this site from that country; I guess they are too busy coping with current events than having fun with Hugo and stuff, and who can fault them for that. |
There was a problem hiding this comment.
This makes a lot of sense. Here is a map of our wonderful planet, where the pink parts refer to places that use the current date format which this PR aims to replace:
While there is a lot of blue there (referring to "day-month-year"), changing to that format would be only confusing to readers who previously had to parse "month/day/year", yet "year-month-date" is still easy to understand in those parts of the world.
As is easy to see, the vast, vast majority of people would have an easier time with the format proposed in this PR. Therefore I am all in favor of this change!
| tree_sha: bc6ce29d1ec757d9d036532531a1046db4da0d96 | ||
| committed: 2014-12-17 19:30:46.000000000 +00:00 | ||
| date: 12/17/14 | ||
| date: '2014-12-17' |
There was a problem hiding this comment.
I hope that you did not do this by hand but instead let the script do its job...
There was a problem hiding this comment.
Darn it, I should have realized that this is affected by the v2.49.0 update.
There was a problem hiding this comment.
I am letting the workflow redo it.
There was a problem hiding this comment.
I merged it into my own fork's gh-pages and deployed it, you can see it in action e.g. here
The script script/update-git-version.rb already uses ISO-8601 dates, which are less confusing for most people. Update script/update-docs.rb to use ISO-8601 date format too. Signed-off-by: Toon Claes <[email protected]>
Updated via the `update-git-version-and-manual-pages.yml` GitHub workflow.
|
My American brain still struggles with this, but I think it's the correct thing to do (and what we do at PlanetScale fwiw). |
Thank you! |
3 participants
Changes
The script script/update-git-version.rb already uses ISO-8601 dates,
which are less confusing for most people.
Update script/update-docs.rb to use ISO-8601 date format too.
Context