@@ -73,7 +73,7 @@ This edition covers what happened during the months of August and September 2024
7373 - "Finish adding a 'os-version' capability to Git protocol v2"
7474 which will be mentored by Christian Couder.
7575
76- See this [ Outreachy webpage] ( https://www.outreachy.org/docs/applicant/ ) ,
76+ See this [ Outreachy webpage] ( https://www.outreachy.org/docs/applicant/ )
7777 for more information about the application process for contributors.
7878
7979### Reviews
@@ -91,11 +91,16 @@ This edition covers what happened during the months of August and September 2024
9191
9292 ` git COMMAND OPTIONS... | tee FILE... `
9393
94- And it's not a good idea to use a pipe after a Git command because
95- pipes discard the exit code of the command before them, so the exit
96- code of the whole line is only the exit code of the command after
97- the pipe, here ` tee ` . In Git tests though, we wouldn't want a test
94+ However, it's not a good idea to use a pipe after a Git command because
95+ pipes discard the exit code of the command before them, so the
96+ standard (Unix) shell behaviour is that the exit code of the whole
97+ sequence is simply the exit code of the last command of a pipe sequence,
98+ here ` tee ` . In Git tests though, we wouldn't want a test
9899 to pass if the Git command fails when it should succeed.
100+ \[ For shell intimates: there are ways to override this default behaviour,
101+ such as the option pipefail for shells that support it, or _ named pipes_
102+ in other cases.
103+ In summary, the root problem can be understood as a portability one.\]
99104
100105 As there was no reason to hide the exit code of the Git commands in
101106 the tests that used ` tee ` , Junio's patch basically just replaced
@@ -212,14 +217,14 @@ _Editor's note: We're starting a new initiative in Git Rev News where
212217* What is your favorite Git-related tool/library, outside of Git
213218 itself?
214219
215- I very like [ GitLens tool] ( https://gitlens.amod.io/ ) when using
220+ I very much like the [ GitLens tool] ( https://gitlens.amod.io/ ) when using
216221 VSCode. By using this tool, I hardly use the bare ` git blame ` command.
217222
218223* What is your toolbox for interacting with the mailing list and for
219224 development of Git?
220225
221226 When reviewing patches, I will firstly use [ ` b4 ` ] ( https://b4.docs.kernel.org/en/latest/ )
222- or simply fetch the branch stored in the Junio's tree and then I will
227+ or simply fetch the branch stored in Junio's tree, and then I will
223228 see the diffs just in the VSCode. To reply to a patch, I download the
224229 raw email and use [ ` mutt ` ] ( http://www.mutt.org/ ) to write contents.
225230 When sending patches, I still use ` mutt ` to make the environment as
0 commit comments