Effectively assure that create_wd_tree() picks up everything.

It's not safe to do that while performing hard resets, and we shouldn't
risk it just yet.

Author: Byron

crates/gitbutler-edit-mode/src/lib.rs

@@ -20,7 +20,6 @@ use gitbutler_operating_modes::{
 };
 use gitbutler_oxidize::{git2_to_gix_object_id, gix_to_git2_index, GixRepositoryExt};
 use gitbutler_project::access::{WorktreeReadPermission, WorktreeWritePermission};
-use gitbutler_project::AUTO_TRACK_LIMIT_BYTES;
 use gitbutler_reference::{ReferenceName, Refname};
 use gitbutler_repo::{rebase::cherry_rebase, RepositoryExt};
 use gitbutler_repo::{signature, SignaturePurpose};
@@ -235,7 +234,9 @@ pub(crate) fn save_and_return_to_workspace(
     let parents = commit.parents().collect::<Vec<_>>();
 
     // Recommit commit
-    let tree = repository.create_wd_tree(AUTO_TRACK_LIMIT_BYTES)?;
+    // While we perform hard resets we should pick up everything to avoid loosing worktree state.
+    let pick_up_untracked_files_of_any_size = 0;
+    let tree = repository.create_wd_tree(pick_up_untracked_files_of_any_size)?;
 
     let (_, committer) = repository.signatures()?;
     let commit_headers = commit

crates/gitbutler-project/src/lib.rs

@@ -20,4 +20,5 @@ pub fn configure_git2() {
 }
 
 /// The maximum size of files to automatically start tracking, i.e. untracked files we pick up for tree-creation.
-pub const AUTO_TRACK_LIMIT_BYTES: u64 = 32 * 1024 * 1024;
+/// **Inactive for now** while it's hard to tell if it's safe *not* to pick up everything.
+pub const AUTO_TRACK_LIMIT_BYTES: u64 = 0;

crates/gitbutler-repo/tests/create_wd_tree.rs

@@ -575,8 +575,8 @@ fn submodule_change() -> anyhow::Result<()> {
 fn big_files_check_is_disabled_with_zero() -> anyhow::Result<()> {
     let test = TestingRepository::open_with_initial_commit(&[]);
 
-    std::fs::write(&test.tempdir.path().join("empty"), "")?;
-    std::fs::write(&test.tempdir.path().join("with-content"), "content")?;
+    std::fs::write(test.tempdir.path().join("empty"), "")?;
+    std::fs::write(test.tempdir.path().join("with-content"), "content")?;
 
     let tree: git2::Tree = test.repository.create_wd_tree(0)?;