Merge pull request #12788 from gitbutlerapp/dp-expect-allow

Replace `#[allow(...)]` with `#[expect(...)]`

Author: davidpdrsn

crates/but-action/src/auto_commit.rs

@@ -59,7 +59,7 @@ impl AutoCommitEvent {
     }
 }
 
-#[allow(clippy::too_many_arguments)]
+#[expect(clippy::too_many_arguments)]
 pub(crate) fn auto_commit(
     project_id: ProjectHandleOrLegacyProjectId,
     repo: &gix::Repository,
@@ -135,7 +135,7 @@ pub(crate) fn auto_commit_simple(
     )
 }
 
-#[allow(clippy::too_many_arguments)]
+#[expect(clippy::too_many_arguments)]
 fn apply_commit_changes(
     project_id: Option<ProjectHandleOrLegacyProjectId>,
     repo: &gix::Repository,

crates/but-action/src/lib.rs

@@ -40,7 +40,7 @@ pub fn branch_changes(
     branch_changes::branch_changes(ctx, llm, changes, model)
 }
 
-#[allow(clippy::too_many_arguments)]
+#[expect(clippy::too_many_arguments)]
 pub fn auto_commit(
     project_id: ProjectHandleOrLegacyProjectId,
     repo: &gix::Repository,

crates/but-api-macros/src/lib.rs

@@ -297,7 +297,7 @@ pub fn but_api(attr: TokenStream, item: TokenStream) -> TokenStream {
         #input_fn
 
         const _: () = {
-            #[allow(dead_code)]
+            #[expect(dead_code)]
             fn keep_json(_json: #json_ty) {}
         };
 

crates/but-api/src/legacy/open.rs

@@ -1,7 +1,6 @@
 //! In place of commands.rs
 use std::env;
 
-#[allow(unused_imports)]
 use anyhow::anyhow;
 use anyhow::{Context as _, Result, bail};
 use but_api_macros::but_api;

crates/but-bot/src/lib.rs

@@ -22,7 +22,7 @@ pub fn bot(
     graph.start(&mut but_bot)
 }
 
-#[allow(clippy::too_many_arguments)]
+#[expect(clippy::too_many_arguments)]
 pub fn forge_branch_chat(
     project_id: ProjectHandleOrLegacyProjectId,
     branch: String,

crates/but-claude/src/claude_transcript.rs

@@ -30,7 +30,7 @@ pub struct AssistantMessage {
 
 #[derive(Debug, Serialize, Deserialize)]
 #[serde(tag = "type")]
-#[allow(clippy::large_enum_variant)]
+#[expect(clippy::large_enum_variant)]
 pub enum Record {
     #[serde(rename = "summary")]
     Summary {

crates/but-claude/src/permissions/patterns.rs

@@ -148,7 +148,6 @@ impl PathPattern {
 }
 
 /// What kind of pattern to serialize as.
-#[allow(dead_code)]
 #[derive(Debug, Clone, Copy, Serialize, Deserialize)]
 pub enum PathPatternKind {
     HomeRelative,

crates/but-claude/src/session.rs

@@ -1590,7 +1590,7 @@ async fn handle_ask_user_question(
 ///    `can_use_tool` callback to work correctly with the SDK's streaming mode.
 /// 2. Performs file locking to track which files are being edited during the session,
 ///    preventing conflicts when Claude modifies files.
-#[allow(unused_variables)]
+#[expect(unused_variables)]
 fn create_pretool_use_hook(
     sync_ctx: ThreadSafeContext,
     stack_id: but_core::ref_metadata::StackId,

crates/but-core/src/tree/mod.rs

@@ -485,7 +485,7 @@ fn to_additive_hunks(
 ///
 /// Note that this algorithm is kind of the opposite of what people would expect if it's run where `to_additive_hunks()` works.
 /// But here we are… just making this work.
-#[allow(clippy::indexing_slicing)]
+#[expect(clippy::indexing_slicing)]
 fn to_additive_hunks_fallback(
     hunks_to_keep: impl IntoIterator<Item = HunkHeader>,
     worktree_hunks: &[HunkHeader],

crates/but-core/src/worktree/checkout/tree.rs

@@ -20,7 +20,7 @@ impl Default for Lut {
     }
 }
 
-#[allow(clippy::indexing_slicing)]
+#[expect(clippy::indexing_slicing)]
 impl Lut {
     /// Insert a node for each component in slash-separated `rela_path`.
     pub fn track_file(&mut self, rela_path: &BStr) {