Merge pull request #10644 from gitbutlerapp/copilot/update-publish-workflow-env-vars

Set LTO and codegen env vars only for release builds with separate Rust caches

Author: Byron

.github/workflows/publish.yaml

@@ -137,7 +137,7 @@ jobs:
       - name: Rust Cache
         uses: Swatinem/[email protected]
         with:
-          shared-key: app-release-build
+          shared-key: app-release-build-${{ github.event.inputs.channel || 'nightly' }}
       - name: Init Node Environment
         uses: ./.github/actions/init-env-node
 
@@ -191,6 +191,13 @@ jobs:
         with:
           name: sveltekit-build
           path: ./apps/desktop/build/
+      - name: Set release build optimization env vars
+        shell: bash
+        if: github.event.inputs.channel == 'release'
+        run: |
+          echo "CARGO_PROFILE_RELEASE_LTO=fat" >> $GITHUB_ENV
+          echo "CARGO_PROFILE_RELEASE_CODEGEN_UNITS=1" >> $GITHUB_ENV
+          echo "CARGO_PROFILE_RELEASE_OPT_LEVEL=s" >> $GITHUB_ENV
       - name: Build binary
         shell: bash
         run: |

Cargo.toml

@@ -101,8 +101,10 @@ rmcp = { version = "0.1.5" }
 serde_json_lenient = "0.2.3"
 
 [profile.release]
-lto = "thin"      # Enables link to optimizations, but don't go all out on compile time.
-opt-level = "s"   # Optimize for binary size
+# There are no overrides here as we optimise for fast release builds,
+# which are used when building locally and when making Nightly builds.
+# The Stable release builds override the relevant settings at release time
+# to optimise for size.
 
 [profile.bench]
 codegen-units = 256