Merge pull request #10360 from gitbutlerapp/copilot/fix-a94ad9dc-8da5-41db-83cb-1ae75addd7ab

Add test to detect JSON defaults vs FeatureFlags struct mismatches

Author: Byron

crates/but-settings/assets/defaults.jsonc

@@ -18,15 +18,13 @@
 		"oauthClientId": "cd51880daa675d9e6452"
 	},
 	"featureFlags": {
-		// Deprecated, was used for the new version of the UI.
-		"v3": true,
 		// Enables the v3 safe checkout.
 		"cv3": false,
 		/// Enable the usage of V3 workspace APIs.
 		"ws3": true,
 		/// Enable undo/redo support.
 		"undo": false,
-		/// Enable the usage of GitButler Acitions.
+		/// Enable the usage of GitButler Actions.
 		"actions": false,
 		/// Enable the usage of the butbot chat.
 		"butbot": false,

crates/but-settings/src/app_settings.rs

@@ -24,7 +24,6 @@ pub struct GitHubOAuthAppSettings {
 #[serde(rename_all = "camelCase")]
 pub struct FeatureFlags {
     /// Enable the usage of V3 workspace APIs.
-    #[serde(default = "default_true")]
     pub ws3: bool,
     /// Turn on the set a v3 version of checkout
     pub cv3: bool,
@@ -53,10 +52,6 @@ pub struct FeatureFlags {
     pub single_branch: bool,
 }
 
-fn default_true() -> bool {
-    true
-}
-
 #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "camelCase")]
 pub struct ExtraCsp {