Skip to content

Commit 2eead4c

Browse files
committed
Fix remaining scroll glitches
- scrollbar glitches gone - bottom stickiness better - inner padding issue fixed
1 parent 31caa47 commit 2eead4c

File tree

7 files changed

+149
-153
lines changed

7 files changed

+149
-153
lines changed

apps/desktop/src/components/Scrollbar.svelte

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<script lang="ts">
22
import { SETTINGS } from '$lib/settings/userSettings';
33
import { inject } from '@gitbutler/core/context';
4-
import { Scrollbar, type ScrollbarPaddingType } from '@gitbutler/ui';
4+
import { Scrollbar } from '@gitbutler/ui';
55
66
interface Props {
77
viewport: HTMLDivElement;
88
initiallyVisible?: boolean;
99
thickness?: string;
10-
padding?: ScrollbarPaddingType;
1110
shift?: string;
1211
horz?: boolean;
1312
zIndex?: string;
@@ -20,7 +19,6 @@
2019
viewport,
2120
initiallyVisible = false,
2221
thickness = '0.563rem',
23-
padding = {},
2422
shift = '0',
2523
horz = false,
2624
zIndex = 'var(--z-lifted)',
@@ -41,7 +39,6 @@
4139
{viewport}
4240
{initiallyVisible}
4341
{thickness}
44-
{padding}
4542
{shift}
4643
{horz}
4744
{zIndex}

apps/desktop/src/components/TargetCommitList.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@
9696
<VirtualList
9797
items={commits}
9898
batchSize={10}
99+
defaultHeight={45}
99100
visibility={$userSettings.scrollbarVisibilityState}
100101
onloadmore={async () => await loadMore()}
101102
>

apps/desktop/src/components/codegen/CodegenMessages.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,8 @@
469469
items={formattedMessages}
470470
batchSize={1}
471471
visibility={$userSettings.scrollbarVisibilityState}
472-
padding={{ left: 20, right: 20 }}
472+
padding={{ left: 20, right: 20, top: 12, bottom: 12 }}
473+
defaultHeight={150}
473474
>
474475
{#snippet chunkTemplate(messages)}
475476
{#each messages as message}

0 commit comments

Comments
 (0)