Delete unused v2 code (VirtualBranchService)

Author: mtsgrd

apps/desktop/src/components/BaseBranchSwitch.svelte

@@ -2,8 +2,8 @@
 	import InfoMessage from '$components/InfoMessage.svelte';
 	import { BaseBranch } from '$lib/baseBranch/baseBranch';
 	import BaseBranchService from '$lib/baseBranch/baseBranchService.svelte';
-	import { VirtualBranchService } from '$lib/branches/virtualBranchService';
 	import { Project } from '$lib/project/project';
+	import { StackService } from '$lib/stacks/stackService.svelte';
 	import { getContext } from '@gitbutler/shared/context';
 	import Button from '@gitbutler/ui/Button.svelte';
 	import SectionCard from '@gitbutler/ui/SectionCard.svelte';
@@ -13,19 +13,17 @@
 	const project = getContext(Project);
 	const projectId = $derived(project.id);
 	const baseBranch = getContext(BaseBranch);
-	const vbranchService = getContext(VirtualBranchService);
+	const stackService = getContext(StackService);
 	const baseBranchService = getContext(BaseBranchService);
 	const remoteBranchesResponse = $derived(baseBranchService.remoteBranches(projectId));
-	const activeBranches = vbranchService.branches;
 	const [setBaseBranchTarget, targetBranchSwitch] = baseBranchService.setTarget;
 
 	let selectedBranch = $state({ name: baseBranch.branchName });
 	let selectedRemote = $state({ name: baseBranch.actualPushRemoteName() });
-	let targetChangeDisabled = $state(false);
 
-	if ($activeBranches) {
-		targetChangeDisabled = $activeBranches.length > 0;
-	}
+	const stacksResult = $derived(stackService.stacks(projectId));
+	const stackCount = $derived(stacksResult.current.data?.length);
+	const targetChangeDisabled = $derived(!!(stackCount && stackCount > 0));
 
 	function uniqueRemotes(remoteBranches: { name: string }[]) {
 		return Array.from(new Set(remoteBranches.map((b) => b.name.split('/')[0]))).map((r) => ({
@@ -39,7 +37,6 @@
 			branch,
 			pushRemote: remote
 		});
-		await vbranchService.refresh();
 	}
 
 	async function onSetBaseBranchClick() {
@@ -109,13 +106,11 @@
 				</Select>
 			{/if}
 
-			{#if $activeBranches && targetChangeDisabled}
+			{#if targetChangeDisabled}
 				<InfoMessage filled outlined={false} icon="info">
 					{#snippet content()}
-						You have {$activeBranches.length === 1
-							? '1 active branch'
-							: `${$activeBranches.length} active branches`} in your workspace. Please clear the workspace
-						before switching the base branch.
+						You have {stackCount === 1 ? '1 active branch' : `${stackCount} active branches`} in your
+						workspace. Please clear the workspace before switching the base branch.
 					{/snippet}
 				</InfoMessage>
 			{:else}

apps/desktop/src/components/NotOnGitButlerBranch.svelte

@@ -5,7 +5,6 @@
 	import RemoveProjectButton from '$components/RemoveProjectButton.svelte';
 	import directionDoubtSvg from '$lib/assets/illustrations/direction-doubt.svg?raw';
 	import BaseBranchService from '$lib/baseBranch/baseBranchService.svelte';
-	import { VirtualBranchService } from '$lib/branches/virtualBranchService';
 	import { ModeService } from '$lib/mode/modeService';
 	import { showError } from '$lib/notifications/toasts';
 	import { Project } from '$lib/project/project';
@@ -29,7 +28,6 @@
 	const { baseBranch }: Props = $props();
 
 	const projectsService = getContext(ProjectsService);
-	const vbranchService = getContext(VirtualBranchService);
 	const baseBranchService = getContext(BaseBranchService);
 	const project = getContext(Project);
 	const [setBaseBranchTarget, targetBranchSwitch] = baseBranchService.setTarget;
@@ -48,7 +46,6 @@
 			pushRemote: remote,
 			stashUncommitted
 		});
-		await vbranchService.refresh();
 	}
 
 	let isDeleting = $state(false);

apps/desktop/src/components/ProjectSetup.svelte

@@ -6,7 +6,6 @@
 	import { PostHogWrapper } from '$lib/analytics/posthog';
 	import newProjectSvg from '$lib/assets/illustrations/new-project.svg?raw';
 	import BaseBranchService from '$lib/baseBranch/baseBranchService.svelte';
-	import { VirtualBranchService } from '$lib/branches/virtualBranchService';
 	import { platformName } from '$lib/platform/platform';
 	import { Project } from '$lib/project/project';
 	import { ProjectsService } from '$lib/project/projectsService';
@@ -24,7 +23,6 @@
 	const projectId = $derived(project.id);
 	const projectsService = getContext(ProjectsService);
 	const baseBranchService = getContext(BaseBranchService);
-	const vbranchService = getContext(VirtualBranchService);
 	const posthog = getContext(PostHogWrapper);
 	const [setBaseBranchTarget] = baseBranchService.setTarget;
 
@@ -47,7 +45,6 @@
 				branch: selectedBranch[0],
 				pushRemote: selectedBranch[1]
 			});
-			await vbranchService.refresh();
 			goto(`/${project.id}/`, { invalidateAll: true });
 		} finally {
 			posthog.capture('Project Setup Complete');

apps/desktop/src/components/StackedPullRequestCard.svelte

@@ -2,7 +2,6 @@
 	import MergeButton from '$components/MergeButton.svelte';
 	import PullRequestCard from '$components/PullRequestCard.svelte';
 	import BaseBranchService from '$lib/baseBranch/baseBranchService.svelte';
-	import { VirtualBranchService } from '$lib/branches/virtualBranchService';
 	import { DefaultForgeFactory } from '$lib/forge/forgeFactory.svelte';
 	import { StackService } from '$lib/stacks/stackService.svelte';
 	import { TestId } from '$lib/testing/testIds';
@@ -20,7 +19,6 @@
 
 	const { projectId, stackId, branchName, prNumber }: Props = $props();
 
-	const vbranchService = getContext(VirtualBranchService);
 	const baseBranchService = getContext(BaseBranchService);
 	const forge = getContext(DefaultForgeFactory);
 	const stackService = getContext(StackService);
@@ -85,7 +83,6 @@
 
 		await Promise.all([
 			baseBranchService.fetchFromRemotes(projectId),
-			vbranchService.refresh(),
 			baseBranchService.refreshBaseBranch(projectId)
 		]);
 	}