Skip to content

Commit 37f0f96

Browse files
committed
Remove ws3 feature flag from frontend
1 parent 6d18d7d commit 37f0f96

File tree

5 files changed

+0
-30
lines changed

5 files changed

+0
-30
lines changed

apps/desktop/cypress/e2e/support/mock/settings.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ export const MOCK_TELEMETRY_SETINGS: TelemetrySettings = {
88
};
99

1010
export const MOCK_FEATURE_FLAGS: FeatureFlags = {
11-
ws3: false,
1211
actions: false,
1312
butbot: false,
1413
rules: false

apps/desktop/src/components/AnalyticsMonitor.svelte

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ attached to posthog events.
6464
eventContext.update({
6565
v3: true,
6666
butlerActions: $settingsService?.featureFlags.actions,
67-
ws3: $settingsService?.featureFlags.ws3,
6867
rules: $settingsService?.featureFlags.rules
6968
});
7069
});

apps/desktop/src/components/profileSettings/ExperimentalSettings.svelte

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -35,23 +35,6 @@
3535
/>
3636
{/snippet}
3737
</SectionCard>
38-
<SectionCard labelFor="ws3" roundedTop={false} roundedBottom={false} orientation="row">
39-
{#snippet title()}
40-
New workspace backend
41-
{/snippet}
42-
{#snippet caption()}
43-
Enable this to use the new API for rendering the workspace state. This should correctly detect
44-
squash-merged PRs as integrated when updating the workspace.
45-
{/snippet}
46-
{#snippet actions()}
47-
<Toggle
48-
id="ws3"
49-
checked={$settingsStore?.featureFlags.ws3}
50-
onclick={() =>
51-
settingsService.updateFeatureFlags({ ws3: !$settingsStore?.featureFlags.ws3 })}
52-
/>
53-
{/snippet}
54-
</SectionCard>
5538
<SectionCard labelFor="rules" roundedTop={false} orientation="row">
5639
{#snippet title()}
5740
Workspace Rules

apps/desktop/src/lib/config/appSettingsV2.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ export type TelemetrySettings = {
8080
};
8181

8282
export type FeatureFlags = {
83-
/** Enable the usage of the V3 workspace API */
84-
ws3: boolean;
8583
/** Enable the usage of GitButler Acitions. */
8684
actions: boolean;
8785
/** Enable the usage of butbot chat */

apps/desktop/src/routes/+layout.svelte

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import { BranchService, BRANCH_SERVICE } from '$lib/branches/branchService.svelte';
2525
import { CommitService, COMMIT_SERVICE } from '$lib/commits/commitService.svelte';
2626
import { APP_SETTINGS } from '$lib/config/appSettings';
27-
import { SETTINGS_SERVICE } from '$lib/config/appSettingsV2';
2827
import { GIT_CONFIG_SERVICE } from '$lib/config/gitConfigService';
2928
import { ircEnabled, ircServer } from '$lib/config/uiFeatureFlags';
3029
import DependencyService, {
@@ -238,7 +237,6 @@
238237
provide(ORGANIZATION_SERVICE, organizationService);
239238
provide(CLOUD_USER_SERVICE, cloudUserService);
240239
provide(HOOKS_SERVICE, data.hooksService);
241-
provide(SETTINGS_SERVICE, data.settingsService);
242240
provide(FILE_SERVICE, data.fileService);
243241
provide(COMMIT_SERVICE, commitService);
244242
@@ -272,9 +270,6 @@
272270
provide(RESIZE_SYNC, new ResizeSync());
273271
provide(GIT_SERVICE, new GitService(data.tauri));
274272
275-
const settingsService = data.settingsService;
276-
const settingsStore = settingsService.appSettings;
277-
278273
// Special initialization to capture pageviews for single page apps.
279274
if (browser) {
280275
beforeNavigate(() => data.posthog.capture('$pageleave'));
@@ -304,10 +299,6 @@
304299
});
305300
306301
const handleKeyDown = createKeybind({
307-
// Toggle v3 workspace APIs on/off
308-
'w s 3': () => {
309-
settingsService.updateFeatureFlags({ ws3: !$settingsStore?.featureFlags.ws3 });
310-
},
311302
// This is a debug tool to see how the commit-graph looks like, the basis for all workspace computation.
312303
// For good measure, it also shows the workspace.
313304
'd o t': async () => {

0 commit comments

Comments
 (0)