Merge pull request #10173 from gitbutlerapp/posthog-ready-onboarding-event

Await PostHog initialization before funnel event

Author: estib-vega

apps/desktop/src/components/AnalyticsConfirmation.svelte

@@ -22,8 +22,10 @@
 			icon="chevron-right-small"
 			onclick={() => {
 				$analyticsConfirmed = true;
-				initAnalyticsIfEnabled(appSettings, posthog);
-				posthog.captureOnboarding(OnboardingEvent.ConfirmedAnalytics);
+				initAnalyticsIfEnabled(appSettings, posthog, true).then(() => {
+					// Await the initialization before logging the event to ensure PostHog is ready
+					posthog.captureOnboarding(OnboardingEvent.ConfirmedAnalytics);
+				});
 			}}
 		>
 			Continue

apps/desktop/src/lib/analytics/analytics.ts

@@ -3,26 +3,30 @@ import { initSentry } from '$lib/analytics/sentry';
 import { AppSettings } from '$lib/config/appSettings';
 import posthog from 'posthog-js';
 
-export function initAnalyticsIfEnabled(appSettings: AppSettings, postHog: PostHogWrapper) {
+export async function initAnalyticsIfEnabled(
+	appSettings: AppSettings,
+	postHog: PostHogWrapper,
+	confirmedOverride?: boolean
+) {
 	if (import.meta.env.MODE === 'development') return;
 
-	appSettings.appAnalyticsConfirmed.onDisk().then(async (confirmed) => {
-		if (confirmed) {
-			appSettings.appErrorReportingEnabled.onDisk().then((enabled) => {
-				if (enabled) initSentry();
-			});
-			await appSettings.appMetricsEnabled.onDisk().then(async (enabled) => {
-				if (enabled) {
-					await postHog.init();
-				}
-			});
-			appSettings.appNonAnonMetricsEnabled.onDisk().then((enabled) => {
-				if (enabled) {
-					posthog.capture('nonAnonMetricsEnabled');
-				} else {
-					posthog.capture('nonAnonMetricsDisabled');
-				}
-			});
-		}
-	});
+	const confirmed = confirmedOverride ?? (await appSettings.appAnalyticsConfirmed.onDisk());
+
+	if (confirmed) {
+		appSettings.appErrorReportingEnabled.onDisk().then((enabled) => {
+			if (enabled) initSentry();
+		});
+		await appSettings.appMetricsEnabled.onDisk().then(async (enabled) => {
+			if (enabled) {
+				await postHog.init();
+			}
+		});
+		appSettings.appNonAnonMetricsEnabled.onDisk().then((enabled) => {
+			if (enabled) {
+				posthog.capture('nonAnonMetricsEnabled');
+			} else {
+				posthog.capture('nonAnonMetricsDisabled');
+			}
+		});
+	}
 }