Convert all usese of allow to expect and fix those that aren't relevant anymore.

Author: Byron

crates/but-action/src/generate.rs

@@ -10,7 +10,7 @@ use schemars::{JsonSchema, schema_for};
 
 use crate::OpenAiProvider;
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 pub fn commit_message_blocking(
     openai: &OpenAiProvider,
     external_summary: &str,

crates/but-action/src/grouping.rs

@@ -15,7 +15,7 @@ pub enum BranchSuggestion {
 }
 
 impl BranchSuggestion {
-    #[allow(dead_code)]
+    #[expect(dead_code)]
     pub fn name(&self) -> String {
         match self {
             BranchSuggestion::New(name) => name.clone(),
@@ -63,7 +63,7 @@ pub struct Grouping {
     pub groups: Vec<Group>,
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 pub fn group(openai: &OpenAiProvider, project_status: &ProjectStatus) -> anyhow::Result<Grouping> {
     let system_message ="
         You are an expert in grouping file changes into logical units for version control.

crates/but-action/src/openai.rs

@@ -19,7 +19,6 @@ use schemars::{JsonSchema, schema_for};
 use serde::de::DeserializeOwned;
 use tokio::sync::Mutex;
 
-#[allow(unused)]
 #[derive(Debug, Clone, serde::Serialize, strum::Display)]
 pub enum CredentialsKind {
     EnvVarOpenAiKey,
@@ -116,7 +115,6 @@ impl OpenAiProvider {
     }
 }
 
-#[allow(dead_code)]
 pub fn structured_output_blocking<
     T: serde::Serialize + DeserializeOwned + JsonSchema + std::marker::Send + 'static,
 >(
@@ -144,7 +142,6 @@ pub fn structured_output_blocking<
     .unwrap()
 }
 
-#[allow(dead_code)]
 pub async fn structured_output<T: serde::Serialize + DeserializeOwned + JsonSchema>(
     client: &Client<OpenAIConfig>,
     messages: Vec<ChatCompletionRequestMessage>,
@@ -177,7 +174,6 @@ pub async fn structured_output<T: serde::Serialize + DeserializeOwned + JsonSche
     Ok(None)
 }
 
-#[allow(dead_code)]
 pub fn tool_calling_blocking(
     client: &OpenAiProvider,
     messages: Vec<ChatCompletionRequestMessage>,
@@ -197,7 +193,6 @@ pub fn tool_calling_blocking(
     .unwrap()
 }
 
-#[allow(dead_code)]
 pub async fn tool_calling(
     client: &Client<OpenAIConfig>,
     messages: Vec<ChatCompletionRequestMessage>,

crates/but-core/src/lib.rs

@@ -350,7 +350,7 @@ pub struct WorktreeChanges {
 /// the *dominant* change to display. Note that it can stack with a content change,
 /// but *should not only in case of a `TypeChange*`*.
 #[derive(Debug, Copy, Clone, PartialEq, Eq)]
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 pub enum ModeFlags {
     ExecutableBitAdded,
     ExecutableBitRemoved,

crates/but-core/src/settings.rs

@@ -21,7 +21,7 @@ pub mod git {
         /// See [`GitConfigSettings`](crate::GitConfigSettings) for the docs.
         #[derive(Debug, PartialEq, Clone, Default, serde::Serialize, serde::Deserialize)]
         #[serde(rename_all = "camelCase")]
-        #[allow(missing_docs)]
+        #[expect(missing_docs)]
         pub struct GitConfigSettings {
             #[serde(rename = "signCommits")]
             pub gitbutler_sign_commits: Option<bool>,

crates/but-core/src/ui.rs

@@ -249,7 +249,7 @@ pub struct ChangeState {
 }
 
 #[derive(Debug, Copy, Clone, PartialEq, Eq, Serialize, Deserialize)]
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 pub enum ModeFlags {
     ExecutableBitAdded,
     ExecutableBitRemoved,

crates/but-graph/src/init/post.rs

@@ -35,7 +35,6 @@ impl Graph {
     /// Now that the graph is complete, perform additional structural improvements with
     /// the requirement of them to be computationally cheap.
     #[instrument(skip(self, meta, repo, refs_by_id), err(Debug))]
-    #[allow(clippy::too_many_arguments)]
     pub(super) fn post_processed<T: RefMetadata>(
         mut self,
         meta: &OverlayMetadata<'_, T>,

crates/but-graph/src/init/walk.rs

@@ -596,7 +596,7 @@ pub fn find(
 /// This means we process all workspaces if we aren't currently and clearly looking at a workspace.
 ///
 /// Also prune all non-standard workspaces early, or those that don't have a tip.
-#[allow(clippy::type_complexity)]
+#[expect(clippy::type_complexity)]
 pub fn obtain_workspace_infos<T: RefMetadata>(
     repo: &OverlayRepo<'_>,
     maybe_ref_name: Option<&gix::refs::FullNameRef>,
@@ -695,7 +695,7 @@ pub fn propagate_flags_downward(
 /// If a remote tracking branch is in `target_refs`, we assume it was already scheduled and won't schedule it again.
 /// Note that remotes fully obey the limit.
 /// If the created remote segment belongs to the segment of `local_tracking_sidx`, return its Segment index along with its name.
-#[allow(clippy::too_many_arguments)]
+#[expect(clippy::too_many_arguments)]
 pub fn try_queue_remote_tracking_branches<T: RefMetadata>(
     repo: &OverlayRepo<'_>,
     refs: &[gix::refs::FullName],

crates/but-graph/tests/graph/init/utils.rs

@@ -40,7 +40,6 @@ pub fn read_only_in_memory_scenario_named(
 }
 
 pub enum StackState {
-    #[allow(dead_code)]
     InWorkspace,
     Inactive,
 }

crates/but-hunk-dependency/src/ranges/mod.rs

@@ -23,7 +23,7 @@ pub struct WorkspaceRanges {
 /// An error that can say what went wrong when computing the hunk ranges for a commit in a stack at a given path.
 #[derive(Debug, Clone, Serialize)]
 #[serde(rename_all = "camelCase")]
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 pub struct CalculationError {
     pub error_message: String,
     pub stack_id: StackId,