Remove v3 feature flag leftovers

Author: krlvi

crates/but-settings/src/api.rs

@@ -15,7 +15,6 @@ pub struct TelemetryUpdate {
 #[serde(rename_all = "camelCase")]
 /// Update request for [`crate::app_settings::FeatureFlags`].
 pub struct FeatureFlagsUpdate {
-    pub v3: Option<bool>,
     pub ws3: Option<bool>,
     pub actions: Option<bool>,
     pub butbot: Option<bool>,
@@ -53,17 +52,13 @@ impl AppSettingsWithDiskSync {
     pub fn update_feature_flags(
         &self,
         FeatureFlagsUpdate {
-            v3,
             ws3,
             actions,
             butbot,
             rules,
         }: FeatureFlagsUpdate,
     ) -> Result<()> {
         let mut settings = self.get_mut_enforce_save()?;
-        if let Some(v3) = v3 {
-            settings.feature_flags.v3 = v3;
-        }
         if let Some(ws3) = ws3 {
             settings.feature_flags.ws3 = ws3;
         }

crates/but-settings/src/app_settings.rs

@@ -23,12 +23,6 @@ pub struct GitHubOAuthAppSettings {
 #[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "camelCase")]
 pub struct FeatureFlags {
-    /// Enables the v3 design, as well as the purgatory mode (no uncommitted diff ownership assignments).
-    #[serde(
-        default = "FeatureFlags::always_true",
-        deserialize_with = "FeatureFlags::deserialize_v3_true"
-    )]
-    pub v3: bool,
     /// Enable the usage of V3 workspace APIs.
     #[serde(default = "default_true")]
     pub ws3: bool,
@@ -59,19 +53,6 @@ fn default_true() -> bool {
     true
 }
 
-impl FeatureFlags {
-    fn always_true() -> bool {
-        true
-    }
-
-    fn deserialize_v3_true<'de, D>(_deserializer: D) -> Result<bool, D::Error>
-    where
-        D: serde::Deserializer<'de>,
-    {
-        Ok(true)
-    }
-}
-
 #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)]
 #[serde(rename_all = "camelCase")]
 pub struct ExtraCsp {

crates/but-testing/src/command/mod.rs

@@ -342,7 +342,6 @@ pub mod stacks {
         // Enable v3 feature flags for the command context
         let app_settings = AppSettings {
             feature_flags: but_settings::app_settings::FeatureFlags {
-                v3: true,
                 ws3,
                 undo: false,
                 actions: false,

crates/but/src/mcp_internal/stack.rs

@@ -30,7 +30,6 @@ pub fn create_stack_with_branch(
     // Enable v3 feature flags for the command context
     let app_settings = AppSettings {
         feature_flags: but_settings::app_settings::FeatureFlags {
-            v3: true,
             // Keep this off until it caught up at least.
             ws3: false,
             undo: false,

crates/but/src/mcp_internal/status.rs

@@ -10,7 +10,6 @@ pub fn project_status(project_dir: &Path) -> anyhow::Result<but_tools::workspace
     // Enable v3 feature flags for the command context
     let app_settings = AppSettings {
         feature_flags: but_settings::app_settings::FeatureFlags {
-            v3: true,
             // Keep this off until it caught up at least.
             ws3: false,
             undo: false,