Remove redundant git_head endpoint

Author: mtsgrd

apps/desktop/cypress/e2e/support/index.ts

@@ -1,7 +1,7 @@
 import { getBaseBranchData, getRemoteBranches } from './mock/baseBranch';
 import { MOCK_BRANCH_LISTINGS } from './mock/branches';
 import { MOCK_TREE_CHANGES, MOCK_UNIFIED_DIFF } from './mock/changes';
-import { MOCK_GIT_HEAD, MOCK_OPEN_WORKSPACE_MODE } from './mock/mode';
+import { MOCK_OPEN_WORKSPACE_MODE } from './mock/mode';
 import { getProject, isGetProjectArgs, listProjects } from './mock/projects';
 import { getSecret, isGetSecretArgs } from './mock/secrets';
 import { MOCK_APP_SETTINGS } from './mock/settings';
@@ -134,8 +134,6 @@ Cypress.on('window:before:load', (win) => {
 				return await Promise.resolve();
 			case 'canned_branch_name':
 				return await Promise.resolve('canned-branch-name');
-			case 'git_head':
-				return MOCK_GIT_HEAD;
 			case 'get_base_branch_data':
 				return getBaseBranchData();
 			case 'git_remote_branches':

apps/desktop/cypress/e2e/support/mock/mode.ts

@@ -1,5 +1,3 @@
-export const MOCK_GIT_HEAD = '1234123';
-
 export const MOCK_OPEN_WORKSPACE_MODE = {
 	type: 'OpenWorkspace'
 };

apps/desktop/src/lib/mode/modeService.ts

@@ -72,10 +72,6 @@ export class ModeService {
 	get mode() {
 		return this.api.endpoints.mode.useQuery;
 	}
-
-	get head() {
-		return this.api.endpoints.mode.useQuery;
-	}
 }
 
 function injectEndpoints(api: ClientState['backendApi']) {
@@ -158,25 +154,6 @@ function injectEndpoints(api: ClientState['backendApi']) {
 					await lifecycleApi.cacheEntryRemoved;
 					unsubscribe();
 				}
-			}),
-			head: build.query<string, { projectId: string }>({
-				extraOptions: { command: 'git_head' },
-				query: (args) => args,
-				providesTags: [providesList(ReduxTag.HeadMetadata)],
-				async onCacheEntryAdded(arg, lifecycleApi) {
-					if (!hasBackendExtra(lifecycleApi.extra)) {
-						throw new Error('Redux dependency Backend not found!');
-					}
-					await lifecycleApi.cacheDataLoaded;
-					const unsubscribe = lifecycleApi.extra.backend.listen<HeadAndMode>(
-						`project://${arg.projectId}/git/head`,
-						(event) => {
-							lifecycleApi.updateCachedData(() => event.payload.head);
-						}
-					);
-					await lifecycleApi.cacheEntryRemoved;
-					unsubscribe();
-				}
 			})
 		})
 	});

apps/desktop/src/routes/[projectId]/+layout.svelte

@@ -86,13 +86,12 @@
 	const stackService = inject(STACK_SERVICE);
 	const worktreeService = inject(WORKTREE_SERVICE);
 
-	const mode = $derived(modeService.mode({ projectId }));
-	const headQuery = $derived(modeService.head({ projectId }));
-	const head = $derived(headQuery.response);
+	const modeQuery = $derived(modeService.mode({ projectId }));
+	const mode = $derived(modeQuery.response);
 
 	// Invalidate stacks when switching branches outside workspace
 	$effect(() => {
-		if (head?.type === 'OutsideWorkspace' && head.subject.branchName) {
+		if (mode?.type === 'OutsideWorkspace' && mode.subject.branchName) {
 			stackService.invalidateStacks();
 		}
 	});
@@ -231,7 +230,7 @@
 
 	// Refresh when branch data changes
 	$effect(() => {
-		if (baseBranch || headQuery.response) debouncedRemoteBranchRefresh();
+		if (baseBranch || modeQuery.response) debouncedRemoteBranchRefresh();
 	});
 
 	// Auto-fetch setup
@@ -326,7 +325,7 @@
 <ProjectSettingsMenuAction {projectId} />
 <FileMenuAction />
 
-<ReduxResult {projectId} result={combineResults(baseBranchQuery.result, mode.result)}>
+<ReduxResult {projectId} result={combineResults(baseBranchQuery.result, modeQuery.result)}>
 	{#snippet children([baseBranch, mode], { projectId })}
 		{#if !baseBranch}
 			<NoBaseBranch {projectId} />

crates/but-api/src/commands/git.rs

@@ -67,16 +67,6 @@ pub fn git_index_size(project_id: ProjectId) -> Result<usize, Error> {
     Ok(size)
 }
 
-#[api_cmd]
-#[tauri::command(async)]
-#[instrument(err(Debug))]
-pub fn git_head(project_id: ProjectId) -> Result<String, Error> {
-    let project = gitbutler_project::get(project_id)?;
-    let ctx = CommandContext::open(&project, AppSettings::load_from_default_path_creating()?)?;
-    let head = ctx.repo().head().context("failed to get repository head")?;
-    Ok(head.name().unwrap().to_string())
-}
-
 #[api_cmd]
 #[tauri::command(async)]
 #[instrument(err(Debug))]

crates/but-server/src/lib.rs

@@ -152,7 +152,6 @@ async fn handle_command(
         "git_test_push" => git::git_test_push_cmd(request.params),
         "git_test_fetch" => git::git_test_fetch_cmd(request.params),
         "git_index_size" => git::git_index_size_cmd(request.params),
-        "git_head" => git::git_head_cmd(request.params),
         "delete_all_data" => git::delete_all_data_cmd(request.params),
         "git_set_global_config" => git::git_set_global_config_cmd(request.params),
         "git_remove_global_config" => git::git_remove_global_config_cmd(request.params),

crates/gitbutler-tauri/src/app.rs

@@ -68,13 +68,6 @@ impl App {
         Ok(size)
     }
 
-    pub fn git_head(&self, project_id: ProjectId, settings: AppSettings) -> Result<String> {
-        let project = gitbutler_project::get(project_id)?;
-        let ctx = CommandContext::open(&project, settings)?;
-        let head = ctx.repo().head().context("failed to get repository head")?;
-        Ok(head.name().unwrap().to_string())
-    }
-
     pub fn git_set_global_config(key: &str, value: &str) -> Result<String> {
         let mut config = git2::Config::open_default()?;
         config.set_str(key, value)?;

crates/gitbutler-tauri/src/main.rs

@@ -207,7 +207,6 @@ fn main() {
                 .plugin(log.build())
                 .invoke_handler(tauri::generate_handler![
                     git::git_remote_branches,
-                    git::git_head,
                     git::delete_all_data,
                     git::git_set_global_config,
                     git::git_remove_global_config,