refactor(mock rename branchName -> branch and use full ref names

Update mock backend and test helpers to use a single "branch" field
containing the git ref (e.g. refs/heads/<name>) instead of the previous
branchName/remote split. Adjust type guards, invocation points, and
fixtures so branch refs are constructed where needed (selection tests
and branch-change scenario data). Improve error messaging in the mock
getBranchChanges to include the incoming args for easier debugging.

This clarifies parameter semantics (full ref vs name), reduces fragile
remote handling, and aligns tests and fixtures with how branch refs are
consumed by the mock backend.

Author: estib-vega

apps/desktop/cypress/e2e/selection.cy.ts

@@ -51,7 +51,8 @@ describe('Selection', () => {
 				.scrollIntoView()
 				.should('be.visible')
 				.within(() => {
-					const changedFileNames = mockBackend.getBranchChangesFileNames(stackId, stackName);
+					const branch = `refs/heads/${stackName}`;
+					const changedFileNames = mockBackend.getBranchChangesFileNames(stackId, branch);
 					for (const fileName of changedFileNames) {
 						cy.getByTestId('file-list-item', fileName).should('be.visible');
 					}

apps/desktop/cypress/e2e/support/mock/backend.ts

@@ -442,10 +442,10 @@ export default class MockBackend {
 
 	public getBranchChanges(args: InvokeArgs | undefined): TreeChanges {
 		if (!args || !isGetBranchChangesParams(args)) {
-			throw new Error('Invalid arguments for getBranchChanges');
+			throw new Error('Invalid arguments for getBranchChanges: ' + JSON.stringify(args));
 		}
 
-		const { stackId, branchName } = args;
+		const { stackId, branch } = args;
 
 		if (!stackId) {
 			return {
@@ -463,9 +463,9 @@ export default class MockBackend {
 			throw new Error(`No changes found for stack with ID ${stackId}`);
 		}
 
-		const branchChanges = stackBranchChanges.get(branchName);
+		const branchChanges = stackBranchChanges.get(branch);
 		if (!branchChanges) {
-			throw new Error(`No changes found for branch with name ${branchName}`);
+			throw new Error(`No changes found for branch with name ${branch}`);
 		}
 
 		return {
@@ -480,10 +480,10 @@ export default class MockBackend {
 
 	public getBranchChangesFileNames(
 		stackId: string,
-		branchName: string,
+		branch: string,
 		projectId: string = PROJECT_ID
 	): string[] {
-		const changes = this.getBranchChanges({ projectId, stackId, branchName });
+		const changes = this.getBranchChanges({ projectId, stackId, branch });
 		return changes.changes.map((change) => change.path).map((path) => path.split('/').pop()!);
 	}
 

apps/desktop/cypress/e2e/support/mock/changes.ts

@@ -148,8 +148,7 @@ export function isGetCommitChangesParams(args: unknown): args is GetCommitChange
 export type GetBranchChangesParams = {
 	projectId: string;
 	stackId?: string;
-	branchName: string;
-	remote?: string;
+	branch: string;
 };
 
 export function isGetBranchChangesParams(args: unknown): args is GetBranchChangesParams {
@@ -159,9 +158,8 @@ export function isGetBranchChangesParams(args: unknown): args is GetBranchChange
 		'projectId' in args &&
 		typeof args['projectId'] === 'string' &&
 		(typeof (args as any).stackId === 'string' || (args as any).stackId === undefined) &&
-		'branchName' in args &&
-		typeof args['branchName'] === 'string' &&
-		(typeof (args as any).remote === 'string' || (args as any).remote === undefined)
+		'branch' in args &&
+		typeof args['branch'] === 'string'
 	);
 }
 

apps/desktop/cypress/e2e/support/scenarios/branchesWithChanges.ts

@@ -635,13 +635,16 @@ export default class BranchesWithChanges extends MockBackend {
 		this.stackDetails.set(MOCK_STACK_C_ID, MOCK_STACK_DETAILS_C);
 
 		const stackAChanges = new Map<string, TreeChange[]>();
-		stackAChanges.set(MOCK_STACK_A_ID, MOCK_BRANCH_A_CHANGES);
+		const branchARef = `refs/heads/${MOCK_STACK_A_ID}`;
+		stackAChanges.set(branchARef, MOCK_BRANCH_A_CHANGES);
 
 		const stackBChanges = new Map<string, TreeChange[]>();
-		stackBChanges.set(MOCK_STACK_B_ID, MOCK_BRANCH_B_CHANGES);
+		const branchBRef = `refs/heads/${MOCK_STACK_B_ID}`;
+		stackBChanges.set(branchBRef, MOCK_BRANCH_B_CHANGES);
 
 		const stackCChanges = new Map<string, TreeChange[]>();
-		stackCChanges.set(MOCK_STACK_C_ID, MOCK_BRANCH_C_CHANGES);
+		const branchCRef = `refs/heads/${MOCK_STACK_C_ID}`;
+		stackCChanges.set(branchCRef, MOCK_BRANCH_C_CHANGES);
 
 		this.branchChanges.set(MOCK_STACK_A_ID, stackAChanges);
 		this.branchChanges.set(MOCK_STACK_B_ID, stackBChanges);