Merge pull request #10453 from gitbutlerapp/observe-update-preference

Fix auto-updater preference not working

Author: Caleb-T-Owens

apps/desktop/src/lib/updater/updater.test.ts

@@ -106,6 +106,24 @@ describe('Updater', () => {
 		}
 		unsubscribe();
 	});
+
+	test('should respect disableAutoChecks setting', async () => {
+		const mock = vi.spyOn(backend, 'checkUpdate').mockReturnValue(mockUpdate(null));
+
+		// Set disableAutoChecks to true
+		updater.disableAutoChecks.set(true);
+
+		// Try to check for updates (should be skipped when disabled)
+		await updater.checkForUpdate();
+		expect(mock).not.toHaveBeenCalled();
+
+		// Set disableAutoChecks to false
+		updater.disableAutoChecks.set(false);
+
+		// Try to check for updates (should work when enabled)
+		await updater.checkForUpdate();
+		expect(mock).toHaveBeenCalledOnce();
+	});
 });
 
 async function mockUpdate(update: Partial<Update> | null): Promise<Update | null> {

apps/desktop/src/lib/updater/updater.ts

@@ -1,5 +1,6 @@
 import { showToast } from '$lib/notifications/toasts';
 import { InjectionToken } from '@gitbutler/core/context';
+import { persisted } from '@gitbutler/shared/persisted';
 import { get, writable } from 'svelte/store';
 import type { PostHogWrapper } from '$lib/analytics/posthog';
 import type {
@@ -46,7 +47,7 @@ export const UPDATE_INTERVAL_MS = 3600000; // Hourly
  * ./scripts/release.sh --channel nightly --version "0.5.678"
  */
 export class UpdaterService {
-	readonly disableAutoChecks = writable(false);
+	readonly disableAutoChecks = persisted(false, 'disableAutoUpdateChecks');
 	readonly loading = writable(false);
 	readonly update = writable<UpdateStatus>({}, () => {
 		this.start();