Skip to content

Commit f85d18c

Browse files
authored
Merge pull request #9467 from gitbutlerapp/fix-cypress-test-review
Fix review.cy.ts test to remove 'it.only'
2 parents acda97c + 272360c commit f85d18c

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

apps/desktop/cypress/e2e/review.cy.ts

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -950,24 +950,19 @@ describe('Review - stacked branches', () => {
950950
cy.wait(
951951
['@getChecksWithActualChecks', '@getChecksWithActualChecks', '@getChecksWithActualChecks'],
952952
{ timeout: 11000 }
953-
).spread((first, second, third) => {
954-
expect(first.response.body).to.deep.equal(data);
955-
expect(second.response.body).to.deep.equal(data);
956-
expect(third.response.body).to.deep.equal(oneCheckFailed);
957-
});
958-
959-
cy.getByTestId('branch-card', mockBackend.topBranchName)
960-
.should('be.visible')
961-
.within(() => {
962-
cy.getByTestId('pr-checks-badge').should('be.visible');
953+
)
954+
.spread((first, second, third) => {
955+
expect(first.response.body).to.deep.equal(data);
956+
expect(second.response.body).to.deep.equal(data);
957+
expect(third.response.body).to.deep.equal(oneCheckFailed);
958+
})
959+
.then(() => {
960+
cy.getByDataValue('pr-text', 'Failed').should('be.visible');
963961
});
964962

965963
cy.getByTestId('stacked-pull-request-card').within(() => {
966964
cy.getByTestId('pr-status-badge').should('be.visible');
967965
cy.getByDataValue('pr-status', 'open').should('be.visible');
968966
});
969-
970-
// TODO: Fix this assertion. The UI shows 'Failed', but the test still fails.
971-
// cy.getByTestId('pr-checks-badge').should('be.visible').contains('Failed').trigger('mouseover');
972967
});
973968
});

apps/desktop/src/components/ChecksPolling.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163
e.stopPropagation();
164164
}}
165165
>
166-
<span class="truncate">
166+
<span data-pr-text={checksTagInfo.reducedText} class="truncate">
167167
{checksTagInfo.reducedText}
168168
</span>
169169
</Badge>

0 commit comments

Comments
 (0)