Skip to content

Commit fd992b0

Browse files
committed
Fix focusable bug
This fixes a thing where a floating commit box did no correctly set the containing focusable as active.
1 parent 64f5a68 commit fd992b0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/ui/src/lib/focus/focusManager.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,18 +89,18 @@ export class FocusManager {
8989
return;
9090
}
9191

92-
// TODO: Allow clicks inside inputs to set `this.currentNode`
93-
if (isInputElement(e.target)) {
94-
return;
95-
}
96-
9792
if (e.target instanceof HTMLElement) {
9893
const focusableNode = this.findNearestFocusableElement(e.target);
9994
if (focusableNode) {
10095
this.setActiveNode(focusableNode);
10196
this.setOutline(false);
10297
}
10398
}
99+
100+
// TODO: Find a way to update the focusable without causing target to blur.
101+
if (isInputElement(e.target)) {
102+
e.target.focus();
103+
}
104104
}
105105

106106
// Handles hotkeys for instant button activation (supports complex combinations like ⇧⌘P)

0 commit comments

Comments
 (0)