LeftHook commit-msg hooks spawn visible shells before executing

[icorbrey]

Version

0.12.26

Operating System

Windows

Distribution Method

msi (Windows)

Describe the issue

I have a Lefthook commit-msg hook that ensures my commit messages are correct semantic commit messages, and it works correctly. However, when run through GitButler it spawns visible shell processes (seemingly while trying to find the system's Lefthook executable since this can be run on many different platforms). This doesn't happen when I commit via the command line or in VSCode.

How to reproduce

1. Install a commit-msg hook with Lefthook.
2. Make a change to a file.
3. Commit the changes.

Expected behavior

No extra windows should appear while waiting for the commit-msg hook to finish.

Relevant log output

No response

[Byron]

Thanks a lot for reporting!

I think the culprit is in the git2-hooks crate which runs a bash like this. This invocation lacks the usual NO_WINDOW flag to suppress the terminal window from showing up:

gitbutler/crates/gitbutler-git/src/executor/tokio/mod.rs

Line 73 in 39099ba

cmd.creation_flags(0x0800_0000); // CREATE_NO_WINDOW

A patch for this would have to be contributed upstream, and the only reason I didn't do this right away was that validating it would take quite a while for me. However, in theory, adding the above to the command should fix the issue right away.

[icorbrey]

No problem! I'll see if I can get a fix in sometime today

[icorbrey]

@Byron I've fixed the functionality upstream (see: gitui-org/gitui#2371), hopefully it doesn't take forever for these changes to be merged in and we can see the benefits in the release build!

[icorbrey]

Looks like git2-hooks@0.4.0 has been released. Should I make a PR to bump the version up?