Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get a minimal viable version of
apply()
that only deals with the common case we can handle today, or simple cases that are new.Follow-up of #10447.
Tasks
but-testing apply
for ease of use in the real-worldWorkspaceCommit::merge()
, but keep it minimalWarning
Current implementation seems does very strange things in conjunction with the 'old' unapply, workspace commit ends up in a strange state and it generally doesn't work as expected.
Next PR?
Future Tasks
gix
code somewhere)but-graph
issueShortcomings
Notes
General Rules
This is as conflicts are currently hidden from view.
apply
is doing something, thenunapply
undoes exactly that, or in other wordsState + apply + unapply == State
commit()
currently can't.uncommit()
as well to all apply-unapply tests so these can later be re-tested with different behaviour.Follow-Ups
Thus:
This is a problem, but we can't have conflicts as the UI doesn't show them right now, nor does it allow interacting with them.
Unapply
apply
just to be able to handle them.Research
Unapply: Assignments - with stashing
However, the user should be able to interact with these.
Unapply: Assignments - with WIP commit
Unapply with worktree changes
Possible Follow-Ups