chore: refactor claude action

[gitcommitshow]

No description provided.

[gitcommitshow]

@claude what do you think of this PR. Will this break anything?

[claude]

Claude finished @gitcommitshow's task —— View job

---

PR Review: claude action refactor

I've analyzed the changes in this PR and here's my comprehensive review:

Todo List:

• Read the current claude.yml workflow file
• Compare changes with git diff to understand what was modified
• Analyze changes for potential breaking issues
• Provide comprehensive review feedback

---

📋 Summary of Changes

The PR makes several important updates to the Claude workflow configuration:

1. Added new trigger: labeled event type for issues
2. Added permissions: actions: read permission
3. New trigger configurations: label_trigger and updated assignee_trigger
4. Refined system prompt: Simplified and clarified instructions
5. Added max turns limit: --max-turns 15

---

🔍 Detailed Analysis

✅ Positive Changes

1. Enhanced Triggering Options

   • Adding labeled trigger provides more flexibility for issue management
   • label_trigger: "claude" allows users to trigger Claude by applying a label

2. Improved Security

   • Added explicit actions: read permission follows least-privilege principle
   • More secure than implicit broad permissions

3. Better Configuration Management

   • assignee_trigger changed from "claude-bot" to "claude[bot]" - better matches GitHub's bot naming convention
   • Added --max-turns 15 prevents infinite loops

4. Cleaner System Prompt

   • Simplified from verbose multi-line instructions to concise guidance
   • Removed redundant "verify branch is found" language

⚠️ Potential Issues & Recommendations

1. Breaking Change - Assignee Trigger 🚨

   - assignee_trigger: "claude-bot"
   + assignee_trigger: "claude[bot]"

   • Impact: If you currently have issues assigned to "claude-bot", they won't trigger Claude anymore
   • Recommendation: Update existing assignments or create a user/bot with the exact name "claude[bot]"

2. System Prompt Simplification

   • Previous: Detailed instructions about branch handling and verification
   • Current: Generic branch creation guidance
   • Impact: Less specific guidance might lead to inconsistent behavior
   • Recommendation: Consider if the more detailed instructions were solving specific issues

3. New Permission Requirements

   • The actions: read permission is good, but ensure your repository has this permission available
   • Should not cause issues in most standard setups

---

🎯 Final Assessment

Will this break anything?

Likely Impact: MINIMAL with one notable exception:

• ✅ New trigger types - Additive, won't break existing functionality
• ✅ Permissions - Conservative addition, should work fine
• ✅ Max turns limit - Protective measure, good addition
• ⚠️ Assignee trigger change - This could break existing workflows if you have issues assigned to "claude-bot"

💡 Recommendations

1. Check existing assignments: Search for issues assigned to "claude-bot" and either:

   • Reassign them to "claude[bot]", or
   • Temporarily revert the assignee_trigger change

2. Test the label trigger: Try adding the "claude" label to an issue to ensure it works as expected

3. Monitor behavior: The simplified system prompt might change Claude's behavior - monitor initial runs

Overall, this is a good refactoring that modernizes the configuration, but the assignee trigger change needs attention to avoid breaking existing workflows.