fix: website address fallback when not set (#85)

Author: gitcommitshow

app.js

@@ -12,6 +12,7 @@ import {
   getMessage,
   isCLARequired,
   isMessageAfterMergeRequired,
+  getWebsiteAddress,
 } from "./src/helpers.js";
 import Slack from "./src/services/Slack.js";
 
@@ -24,7 +25,6 @@ try {
   console.error("Failed to get the version number");
 }
 console.log(`Application version: ${APP_VERSION}`);
-console.log(`Website address: ${process.env.WEBSITE_ADDRESS}`);
 
 // Set configured values
 const appId = process.env.APP_ID;
@@ -211,6 +211,7 @@ app.webhooks.onError((error) => {
 const port = process.env.PORT || 3000;
 const webhookPath = "/api/webhook";
 const localWebhookUrl = `http://localhost:${port}${webhookPath}`;
+const publicWebhookUrl = getWebsiteAddress() + webhookPath;
 
 // See https://github.com/octokit/webhooks.js/#createnodemiddleware for all options
 const middleware = createNodeMiddleware(app.webhooks, { path: webhookPath });
@@ -258,9 +259,13 @@ http
     }
   })
   .listen(port, () => {
-    console.log(`Server is listening for events at: ${localWebhookUrl}`);
     console.log(
-      "Server is also serving the homepage at: http://localhost:" + port
+      "Server is running at:",
+      `\n   Local: http://localhost:${port}`,
+      `\n   Public: ${getWebsiteAddress()}`
     );
+    console.log("Listening for webhook events at:",
+      `\n   Local webhook url: ${localWebhookUrl}`,
+      `\n   Public webhook url: ${publicWebhookUrl}`);
     console.log("Press Ctrl + C to quit.");
   });

src/helpers.js

@@ -365,7 +365,7 @@ export function getMessage(name, context) {
   switch (name) {
     case "ask-to-sign-cla":
       const CLA_LINK =
-        process.env.WEBSITE_ADDRESS +
+        getWebsiteAddress() +
         "/cla" +
         `?org=${context.org}&repo=${context.repo}&prNumber=${context.pr_number}&username=${context.username}`;
       message = `Thank you @${context.username} for contributing this PR.
@@ -793,3 +793,21 @@ export async function getPullRequestDetail(app, owner, repo, number) {
   });
   return pr;
 }
+
+export function getWebsiteAddress() {
+  // 1: WEBSITE_ADDRESS if set by the dev
+  if (process.env.WEBSITE_ADDRESS) {
+    return process.env.WEBSITE_ADDRESS;
+  }
+  const port = process.env.PORT || 3000;
+  // 2: Construct url for the staging server on CodeSandbox
+  if (process.env.CODESANDBOX_HOST) {
+    return `https://${process.env.HOSTNAME}-${port}.csb.app`;
+  }
+  if (process.env.NODE_ENV === 'production'){
+    console.error("Admin Notice: WEBSITE_ADDRESS is not set in env. This will break CLA functionality.");
+    return "WEBSITE_ADDRESS_NOT_SET: Contact admin";
+  }
+  // 3: Last resort: localhost
+  return `http://localhost:${port}`;
+}