Skip to content

Commit ab1a294

Browse files
committed
Fix DependencyNuGetPackageFilter when some dependency is missing.
Before this fix, it logged a message that the tested package is missing a dependency and jumped on next line where it throws NRE.
1 parent ad08227 commit ab1a294

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/PackageManager.UI/Services/DependencyNuGetPackageFilter.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public async Task<NuGetPackageFilterResult> FilterAsync(SourceRepository reposit
4343
if (resource == null)
4444
return NuGetPackageFilterResult.NotCompatible;
4545

46-
NuGetPackageFilterResult result = NuGetPackageFilterResult.Ok;
4746
foreach (NuGetFramework framework in frameworks)
4847
{
4948
SourcePackageDependencyInfo dependencyInfo = await resource.ResolvePackage(package.Identity, framework, new SourceCacheContext(), nuGetLogger, cancellationToken);
@@ -58,7 +57,7 @@ public async Task<NuGetPackageFilterResult> FilterAsync(SourceRepository reposit
5857
if (packageDependency == null)
5958
{
6059
log.Info($"Package '{package.Identity}' skipped: missing dependency '{dependency.Id}'.");
61-
result = NuGetPackageFilterResult.NotCompatible;
60+
return NuGetPackageFilterResult.NotCompatible;
6261
}
6362

6463
if (dependency.Version != null && !packageDependency.VersionRange.Satisfies(new NuGetVersion(dependency.Version)))
@@ -68,7 +67,7 @@ public async Task<NuGetPackageFilterResult> FilterAsync(SourceRepository reposit
6867
}
6968
}
7069

71-
return result;
70+
return NuGetPackageFilterResult.Ok;
7271
}
7372

7473
}

0 commit comments

Comments
 (0)