bugfix: ignore specific ActiveDocument exception (#7677)

itsho · web-flow · commit a6e17ae871ae · 2020-02-29T22:58:42.000+01:00
* bugfix: ignore specific ActiveDocument exception

When there's no active document. for example - "project properties" dialog, 
calling application.ActiveDocument will throw the following exception:
"The parameter is incorrect. (Exception from HRESULT: 0x80070057 (E_INVALIDARG))"

* Sign off contributors.txt
diff --git a/Commands/ItemCommandBase.cs b/Commands/ItemCommandBase.cs
@@ -14,7 +14,15 @@ public override void OnCommand(_DTE application, OutputWindowPane pane)
         {
             if (!RunForSelection)
             {
-                var activeDocument = application.ActiveDocument;
+                Document activeDocument = null;
+                try
+                {
+                    activeDocument = application.ActiveDocument;
+                }
+                catch (Exception)
+                {
+                    // It can fail when there's no active document. for example - "project properties" dialog.
+                }
 
                 if (activeDocument?.ProjectItem == null)
                 {

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,15 @@ public override void OnCommand(_DTE application, OutputWindowPane pane)`
`14`	`14`	`{`
`15`	`15`	`if (!RunForSelection)`
`16`	`16`	`{`
`17`		`- var activeDocument = application.ActiveDocument;`
	`17`	`+ Document activeDocument = null;`
	`18`	`+ try`
	`19`	`+ {`
	`20`	`+ activeDocument = application.ActiveDocument;`
	`21`	`+ }`
	`22`	`+ catch (Exception)`
	`23`	`+ {`
	`24`	`+ // It can fail when there's no active document. for example - "project properties" dialog.`
	`25`	`+ }`
`18`	`26`
`19`	`27`	`if (activeDocument?.ProjectItem == null)`
`20`	`28`	`{`