Skip to content

Commit 0188b2c

Browse files
phil-blaingitster
authored andcommitted
ci(github): also skip logs of broken test cases
When a test fails in the GitHub Actions CI pipeline, we mark it up using special GitHub syntax so it stands out when looking at the run log. We also mark up "fixed" test cases, and skip passing tests since we want to concentrate on the failures. The finalize_test_case_output function in test-lib-github-workflow-markup.sh which performs this markup is however missing a fourth case: "broken" tests, i.e. tests using 'test_expect_failure' to document a known bug. This leads to these "broken" tests appearing along with any failed tests, potentially confusing the reader who might not be aware that "broken" is the status for 'test_expect_failure' tests that indeed failed, and wondering what their commits "broke". Also skip these "broken" tests so that only failures and fixed tests stand out. Signed-off-by: Philippe Blain <[email protected]> Acked-by: Victoria Dye <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 564d025 commit 0188b2c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/test-lib-github-workflow-markup.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ finalize_test_case_output () {
4242
fixed)
4343
echo >>$github_markup_output "::notice::fixed: $this_test.$test_count $1"
4444
;;
45-
ok)
46-
# Exit without printing the "ok" tests
45+
ok|broken)
46+
# Exit without printing the "ok" or ""broken" tests
4747
return
4848
;;
4949
esac

0 commit comments

Comments
 (0)